From c20cb28fafaa7c255adccfa3040998fc29628ab9 Mon Sep 17 00:00:00 2001 From: Tomas Vanek Date: Tue, 5 Sep 2023 18:52:38 +0200 Subject: [PATCH] flash/nor: remove useless bank->next = NULL struct flash_bank must be zeroed anyway, calloc() is always used. Signed-off-by: Tomas Vanek Change-Id: I7ab3b9c66f99688c6095a0a547a05448c9e37d68 Reviewed-on: https://review.openocd.org/c/openocd/+/7885 Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/flash/nor/at91sam7.c | 2 -- src/flash/nor/cc26xx.c | 1 - src/flash/nor/cc3220sf.c | 1 - src/flash/nor/npcx.c | 1 - 4 files changed, 5 deletions(-) diff --git a/src/flash/nor/at91sam7.c b/src/flash/nor/at91sam7.c index 8bb2994ed1..6879a1bf23 100644 --- a/src/flash/nor/at91sam7.c +++ b/src/flash/nor/at91sam7.c @@ -576,7 +576,6 @@ static int at91sam7_read_part_info(struct flash_bank *bank) return ERROR_FAIL; } fb->name = strdup("sam7_probed"); - fb->next = NULL; /* link created bank in 'flash_banks' list */ t_bank->next = fb; @@ -765,7 +764,6 @@ FLASH_BANK_COMMAND_HANDLER(at91sam7_flash_bank_command) return ERROR_FAIL; } fb->name = strdup("sam7_probed"); - fb->next = NULL; /* link created bank in 'flash_banks' list */ t_bank->next = fb; diff --git a/src/flash/nor/cc26xx.c b/src/flash/nor/cc26xx.c index 6256ba6e71..54d61421ce 100644 --- a/src/flash/nor/cc26xx.c +++ b/src/flash/nor/cc26xx.c @@ -261,7 +261,6 @@ FLASH_BANK_COMMAND_HANDLER(cc26xx_flash_bank_command) /* Finish initialization of bank */ bank->driver_priv = cc26xx_bank; - bank->next = NULL; return ERROR_OK; } diff --git a/src/flash/nor/cc3220sf.c b/src/flash/nor/cc3220sf.c index 432a393f8b..74cb7aea57 100644 --- a/src/flash/nor/cc3220sf.c +++ b/src/flash/nor/cc3220sf.c @@ -96,7 +96,6 @@ FLASH_BANK_COMMAND_HANDLER(cc3220sf_flash_bank_command) /* Finish initialization of flash bank */ bank->driver_priv = cc3220sf_bank; - bank->next = NULL; return ERROR_OK; } diff --git a/src/flash/nor/npcx.c b/src/flash/nor/npcx.c index 4a301f1e98..8309630d7c 100644 --- a/src/flash/nor/npcx.c +++ b/src/flash/nor/npcx.c @@ -331,7 +331,6 @@ FLASH_BANK_COMMAND_HANDLER(npcx_flash_bank_command) /* Finish initialization of bank */ bank->driver_priv = npcx_bank; - bank->next = NULL; return ERROR_OK; } -- 2.30.2