From d6ae732f6e1646742bb179c5247ea6a96acfc47e Mon Sep 17 00:00:00 2001 From: Daniel Anselmi Date: Sun, 2 Oct 2022 17:15:41 +0200 Subject: [PATCH] fix leaky file-handle in virtex2 driver Change-Id: I2784a66c42be71f2982dff7746f9fb2eb1dc8ca6 Signed-off-by: Daniel Anselmi Reviewed-on: https://review.openocd.org/c/openocd/+/7243 Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/pld/xilinx_bit.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pld/xilinx_bit.c b/src/pld/xilinx_bit.c index 7911b8dc14..792b3375b6 100644 --- a/src/pld/xilinx_bit.c +++ b/src/pld/xilinx_bit.c @@ -96,31 +96,37 @@ int xilinx_read_bit_file(struct xilinx_bit_file *bit_file, const char *filename) read_count = fread(bit_file->unknown_header, 1, 13, input_file); if (read_count != 13) { LOG_ERROR("couldn't read unknown_header from file '%s'", filename); + fclose(input_file); return ERROR_PLD_FILE_LOAD_FAILED; } if (read_section(input_file, 2, 'a', NULL, &bit_file->source_file) != ERROR_OK) { xilinx_free_bit_file(bit_file); + fclose(input_file); return ERROR_PLD_FILE_LOAD_FAILED; } if (read_section(input_file, 2, 'b', NULL, &bit_file->part_name) != ERROR_OK) { xilinx_free_bit_file(bit_file); + fclose(input_file); return ERROR_PLD_FILE_LOAD_FAILED; } if (read_section(input_file, 2, 'c', NULL, &bit_file->date) != ERROR_OK) { xilinx_free_bit_file(bit_file); + fclose(input_file); return ERROR_PLD_FILE_LOAD_FAILED; } if (read_section(input_file, 2, 'd', NULL, &bit_file->time) != ERROR_OK) { xilinx_free_bit_file(bit_file); + fclose(input_file); return ERROR_PLD_FILE_LOAD_FAILED; } if (read_section(input_file, 4, 'e', &bit_file->length, &bit_file->data) != ERROR_OK) { xilinx_free_bit_file(bit_file); + fclose(input_file); return ERROR_PLD_FILE_LOAD_FAILED; } -- 2.30.2