From d983114855eaf7ab6c63f0e5e6a553096e862a31 Mon Sep 17 00:00:00 2001 From: Daniel Anselmi Date: Sun, 2 Oct 2022 02:16:28 +0200 Subject: [PATCH] don't return ERROR_OK in error cases Change-Id: I7e046df85838692c9044fe9c9d67e8b2c821eb0f Signed-off-by: Daniel Anselmi Reviewed-on: https://review.openocd.org/c/openocd/+/7236 Reviewed-by: Antonio Borneo Tested-by: jenkins --- src/pld/virtex2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pld/virtex2.c b/src/pld/virtex2.c index b4861e9cb8..98fd58adbb 100644 --- a/src/pld/virtex2.c +++ b/src/pld/virtex2.c @@ -175,7 +175,7 @@ COMMAND_HANDLER(virtex2_handle_read_stat_command) device = get_pld_device_by_num(dev_id); if (!device) { command_print(CMD, "pld device '#%s' is out of bounds", CMD_ARGV[0]); - return ERROR_OK; + return ERROR_FAIL; } virtex2_read_stat(device, &status); @@ -197,7 +197,7 @@ PLD_DEVICE_COMMAND_HANDLER(virtex2_pld_device_command) tap = jtag_tap_by_string(CMD_ARGV[1]); if (!tap) { command_print(CMD, "Tap: %s does not exist", CMD_ARGV[1]); - return ERROR_OK; + return ERROR_FAIL; } virtex2_info = malloc(sizeof(struct virtex2_pld_device)); -- 2.30.2