int add_connection(service_t *service, command_context_t *cmd_ctx)
{
unsigned int address_size;
- connection_t *c, *p;
+ connection_t *c, **p;
int retval;
c = malloc(sizeof(connection_t));
free(c);
}
- if (service->connections)
- {
- for (p = service->connections; p && p->next; p = p->next);
- if (p)
- p->next = c;
- }
- else
- {
- service->connections = c;
- }
+ /* add to the end of linked list */
+ for (p = &service->connections; *p; p = &(*p)->next);
+ *p = c;
service->max_connections--;
int remove_connection(service_t *service, connection_t *connection)
{
- connection_t *c = service->connections;
+ connection_t **p = &service->connections;
+ connection_t *c;
/* find connection */
- while(c)
- {
- connection_t *next = c->next;
-
+ while((c = *p))
+ {
if (c->fd == connection->fd)
{
- service->connections = next;
service->connection_closed(c);
close_socket(c->fd);
-
command_done(c->cmd_ctx);
/* delete connection */
+ *p = c->next;
free(c);
service->max_connections++;
break;
}
- /* remember the last connection for unlinking */
- c = next;
+ /* redirect p to next list pointer */
+ p = &(*p)->next;
}
return ERROR_OK;
int add_service(char *name, enum connection_type type, unsigned short port, int max_connections, new_connection_handler_t new_connection_handler, input_handler_t input_handler, connection_closed_handler_t connection_closed_handler, void *priv)
{
- service_t *c, *p;
+ service_t *c, **p;
int so_reuseaddr_option = 1;
c = malloc(sizeof(service_t));
exit(-1);
}
- if (services)
- {
- for (p = services; p && p->next; p = p->next);
- if (p)
- p->next = c;
- }
- else
- {
- services = c;
- }
+ /* add to the end of linked list */
+ for (p = &services; *p; p = &(*p)->next);
+ *p = c;
return ERROR_OK;
}
int remove_service(unsigned short port)
{
- service_t *c = services;
+ service_t **p = &services;
+ service_t *c;
/* find service */
- while(c)
- {
- service_t *next = c->next;
-
+ while((c = *p))
+ {
if (c->port == port)
{
if (c->name)
free(c->priv);
/* delete service */
+ *p = c->next;
free(c);
}
-
- /* remember the last service for unlinking */
- c = next;
+
+ /* redirect p to next list pointer */
+ p = &(*p)->next;
}
return ERROR_OK;
c = next;
}
+ services = NULL;
+
return ERROR_OK;
}
FD_SET(fileno(stdin), &read_fds);
#endif
- if ((retval = select(fd_max + 1, &read_fds, NULL, NULL, &tv)) == -1)
+ retval = select(fd_max + 1, &read_fds, NULL, NULL, &tv);
+
+ if (retval == -1)
{
#ifdef _WIN32
#else
if (errno == EINTR)
+ {
FD_ZERO(&read_fds);
+ }
else
{
ERROR("error during select: %s", strerror(errno));
/* do regular tasks after at most 100ms */
tv.tv_sec = 0;
tv.tv_usec = 10000;
-
-#if 0
- if (shutdown_openocd)
- return ERROR_COMMAND_CLOSE_CONNECTION;
-
- handle_target();
-#endif
+ FD_ZERO(&read_fds); /* eCos leaves read_fds unchanged in this case! */
}
for (service = services; service; service = service->next)
&& (FD_ISSET(service->fd, &read_fds)))
{
if (service->max_connections > 0)
+ {
add_connection(service, command_context);
+ }
else
{
struct sockaddr_in sin;
return ERROR_COMMAND_CLOSE_CONNECTION;
}
+