1 /***************************************************************************
2 * Copyright (C) 2005 by Dominic Rath *
3 * Dominic.Rath@gmx.de *
5 * Copyright (C) 2007-2010 Øyvind Harboe *
6 * oyvind.harboe@zylin.com *
8 * Copyright (C) 2008 by Spencer Oliver *
9 * spen@spen-soft.co.uk *
11 * Copyright (C) 2011 by Broadcom Corporation *
12 * Evan Hunter - ehunter@broadcom.com *
14 * Copyright (C) ST-Ericsson SA 2011 *
15 * michel.jaouen@stericsson.com : smp minimum support *
17 * Copyright (C) 2013 Andes Technology *
18 * Hsiangkai Wang <hkwang@andestech.com> *
20 * Copyright (C) 2013 Franck Jullien *
21 * elec4fun@gmail.com *
23 * This program is free software; you can redistribute it and/or modify *
24 * it under the terms of the GNU General Public License as published by *
25 * the Free Software Foundation; either version 2 of the License, or *
26 * (at your option) any later version. *
28 * This program is distributed in the hope that it will be useful, *
29 * but WITHOUT ANY WARRANTY; without even the implied warranty of *
30 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
31 * GNU General Public License for more details. *
33 * You should have received a copy of the GNU General Public License *
34 * along with this program. If not, see <http://www.gnu.org/licenses/>. *
35 ***************************************************************************/
41 #include <target/breakpoints.h>
42 #include <target/target_request.h>
43 #include <target/register.h>
44 #include <target/target.h>
45 #include <target/target_type.h>
46 #include <target/semihosting_common.h>
48 #include <flash/nor/core.h>
49 #include "gdb_server.h"
50 #include <target/image.h>
51 #include <jtag/jtag.h>
52 #include "rtos/rtos.h"
53 #include "target/smp.h"
57 * GDB server implementation.
59 * This implements the GDB Remote Serial Protocol, over TCP connections,
60 * giving GDB access to the JTAG or other hardware debugging facilities
61 * found in most modern embedded processors.
64 struct target_desc_format
{
66 uint32_t tdesc_length
;
69 /* private connection data for GDB */
70 struct gdb_connection
{
71 char buffer
[GDB_BUFFER_SIZE
+ 1]; /* Extra byte for null-termination */
75 enum target_state frontend_state
;
76 struct image
*vflash_image
;
80 /* set flag to true if you want the next stepi to return immediately.
81 * allowing GDB to pick up a fresh set of register values from the target
82 * without modifying the target state. */
84 /* We delay reporting memory write errors until next step/continue or memory
85 * write. This improves performance of gdb load significantly as the GDB packet
86 * can be replied immediately and a new GDB packet will be ready without delay
87 * (ca. 10% or so...). */
89 /* with extended-remote it seems we need to better emulate attach/detach.
90 * what this means is we reply with a W stop reply after a kill packet,
91 * normally we reply with a S reply via gdb_last_signal_packet.
92 * as a side note this behaviour only effects gdb > 6.8 */
94 /* set when extended protocol is used */
95 bool extended_protocol
;
96 /* temporarily used for target description support */
97 struct target_desc_format target_desc
;
98 /* temporarily used for thread list support */
103 #define _DEBUG_GDB_IO_
106 static struct gdb_connection
*current_gdb_connection
;
108 static int gdb_breakpoint_override
;
109 static enum breakpoint_type gdb_breakpoint_override_type
;
111 static int gdb_error(struct connection
*connection
, int retval
);
112 static char *gdb_port
;
113 static char *gdb_port_next
;
115 static void gdb_log_callback(void *priv
, const char *file
, unsigned line
,
116 const char *function
, const char *string
);
118 static void gdb_sig_halted(struct connection
*connection
);
120 /* number of gdb connections, mainly to suppress gdb related debugging spam
121 * in helper/log.c when no gdb connections are actually active */
122 int gdb_actual_connections
;
124 /* set if we are sending a memory map to gdb
125 * via qXfer:memory-map:read packet */
126 /* enabled by default*/
127 static int gdb_use_memory_map
= 1;
128 /* enabled by default*/
129 static int gdb_flash_program
= 1;
131 /* if set, data aborts cause an error to be reported in memory read packets
132 * see the code in gdb_read_memory_packet() for further explanations.
133 * Disabled by default.
135 static int gdb_report_data_abort
;
136 /* If set, errors when accessing registers are reported to gdb. Disabled by
138 static int gdb_report_register_access_error
;
140 /* set if we are sending target descriptions to gdb
141 * via qXfer:features:read packet */
142 /* enabled by default */
143 static int gdb_use_target_description
= 1;
145 /* current processing free-run type, used by file-I/O */
146 static char gdb_running_type
;
148 static int gdb_last_signal(struct target
*target
)
150 switch (target
->debug_reason
) {
151 case DBG_REASON_DBGRQ
:
152 return 0x2; /* SIGINT */
153 case DBG_REASON_BREAKPOINT
:
154 case DBG_REASON_WATCHPOINT
:
155 case DBG_REASON_WPTANDBKPT
:
156 return 0x05; /* SIGTRAP */
157 case DBG_REASON_SINGLESTEP
:
158 return 0x05; /* SIGTRAP */
159 case DBG_REASON_EXC_CATCH
:
161 case DBG_REASON_NOTHALTED
:
162 return 0x0; /* no signal... shouldn't happen */
164 LOG_USER("undefined debug reason %d - target needs reset",
165 target
->debug_reason
);
170 static int check_pending(struct connection
*connection
,
171 int timeout_s
, int *got_data
)
173 /* a non-blocking socket will block if there is 0 bytes available on the socket,
174 * but return with as many bytes as are available immediately
178 struct gdb_connection
*gdb_con
= connection
->priv
;
184 if (gdb_con
->buf_cnt
> 0) {
190 FD_SET(connection
->fd
, &read_fds
);
192 tv
.tv_sec
= timeout_s
;
194 if (socket_select(connection
->fd
+ 1, &read_fds
, NULL
, NULL
, &tv
) == 0) {
195 /* This can typically be because a "monitor" command took too long
196 * before printing any progress messages
199 return ERROR_GDB_TIMEOUT
;
203 *got_data
= FD_ISSET(connection
->fd
, &read_fds
) != 0;
207 static int gdb_get_char_inner(struct connection
*connection
, int *next_char
)
209 struct gdb_connection
*gdb_con
= connection
->priv
;
210 int retval
= ERROR_OK
;
212 #ifdef _DEBUG_GDB_IO_
216 if (connection
->service
->type
!= CONNECTION_TCP
)
217 gdb_con
->buf_cnt
= read(connection
->fd
, gdb_con
->buffer
, GDB_BUFFER_SIZE
);
219 retval
= check_pending(connection
, 1, NULL
);
220 if (retval
!= ERROR_OK
)
222 gdb_con
->buf_cnt
= read_socket(connection
->fd
,
227 if (gdb_con
->buf_cnt
> 0)
229 if (gdb_con
->buf_cnt
== 0) {
230 LOG_DEBUG("GDB connection closed by the remote client");
231 gdb_con
->closed
= true;
232 return ERROR_SERVER_REMOTE_CLOSED
;
236 errno
= WSAGetLastError();
242 case WSAECONNABORTED
:
243 gdb_con
->closed
= true;
244 return ERROR_SERVER_REMOTE_CLOSED
;
246 gdb_con
->closed
= true;
247 return ERROR_SERVER_REMOTE_CLOSED
;
249 LOG_ERROR("read: %d", errno
);
258 gdb_con
->closed
= true;
259 return ERROR_SERVER_REMOTE_CLOSED
;
261 gdb_con
->closed
= true;
262 return ERROR_SERVER_REMOTE_CLOSED
;
264 LOG_ERROR("read: %s", strerror(errno
));
265 gdb_con
->closed
= true;
266 return ERROR_SERVER_REMOTE_CLOSED
;
271 #ifdef _DEBUG_GDB_IO_
272 debug_buffer
= strndup(gdb_con
->buffer
, gdb_con
->buf_cnt
);
273 LOG_DEBUG("received '%s'", debug_buffer
);
277 gdb_con
->buf_p
= gdb_con
->buffer
;
279 *next_char
= *(gdb_con
->buf_p
++);
280 if (gdb_con
->buf_cnt
> 0)
281 connection
->input_pending
= true;
283 connection
->input_pending
= false;
284 #ifdef _DEBUG_GDB_IO_
285 LOG_DEBUG("returned char '%c' (0x%2.2x)", *next_char
, *next_char
);
292 * The cool thing about this fn is that it allows buf_p and buf_cnt to be
293 * held in registers in the inner loop.
295 * For small caches and embedded systems this is important!
297 static inline int gdb_get_char_fast(struct connection
*connection
,
298 int *next_char
, char **buf_p
, int *buf_cnt
)
300 int retval
= ERROR_OK
;
302 if ((*buf_cnt
)-- > 0) {
303 *next_char
= **buf_p
;
306 connection
->input_pending
= true;
308 connection
->input_pending
= false;
310 #ifdef _DEBUG_GDB_IO_
311 LOG_DEBUG("returned char '%c' (0x%2.2x)", *next_char
, *next_char
);
317 struct gdb_connection
*gdb_con
= connection
->priv
;
318 gdb_con
->buf_p
= *buf_p
;
319 gdb_con
->buf_cnt
= *buf_cnt
;
320 retval
= gdb_get_char_inner(connection
, next_char
);
321 *buf_p
= gdb_con
->buf_p
;
322 *buf_cnt
= gdb_con
->buf_cnt
;
327 static int gdb_get_char(struct connection
*connection
, int *next_char
)
329 struct gdb_connection
*gdb_con
= connection
->priv
;
330 return gdb_get_char_fast(connection
, next_char
, &gdb_con
->buf_p
, &gdb_con
->buf_cnt
);
333 static int gdb_putback_char(struct connection
*connection
, int last_char
)
335 struct gdb_connection
*gdb_con
= connection
->priv
;
337 if (gdb_con
->buf_p
> gdb_con
->buffer
) {
338 *(--gdb_con
->buf_p
) = last_char
;
341 LOG_ERROR("BUG: couldn't put character back");
346 /* The only way we can detect that the socket is closed is the first time
347 * we write to it, we will fail. Subsequent write operations will
348 * succeed. Shudder! */
349 static int gdb_write(struct connection
*connection
, void *data
, int len
)
351 struct gdb_connection
*gdb_con
= connection
->priv
;
352 if (gdb_con
->closed
) {
353 LOG_DEBUG("GDB socket marked as closed, cannot write to it.");
354 return ERROR_SERVER_REMOTE_CLOSED
;
357 if (connection_write(connection
, data
, len
) == len
)
360 LOG_WARNING("Error writing to GDB socket. Dropping the connection.");
361 gdb_con
->closed
= true;
362 return ERROR_SERVER_REMOTE_CLOSED
;
365 static void gdb_log_incoming_packet(char *packet
)
367 if (!LOG_LEVEL_IS(LOG_LVL_DEBUG
))
370 /* Avoid dumping non-printable characters to the terminal */
371 const unsigned packet_len
= strlen(packet
);
372 const char *nonprint
= find_nonprint_char(packet
, packet_len
);
374 /* Does packet at least have a prefix that is printable?
375 * Look within the first 50 chars of the packet. */
376 const char *colon
= memchr(packet
, ':', MIN(50, packet_len
));
377 const bool packet_has_prefix
= (colon
);
378 const bool packet_prefix_printable
= (packet_has_prefix
&& nonprint
> colon
);
380 if (packet_prefix_printable
) {
381 const unsigned int prefix_len
= colon
- packet
+ 1; /* + 1 to include the ':' */
382 const unsigned int payload_len
= packet_len
- prefix_len
;
383 LOG_DEBUG("received packet: %.*s<binary-data-%u-bytes>", prefix_len
, packet
, payload_len
);
385 LOG_DEBUG("received packet: <binary-data-%u-bytes>", packet_len
);
388 /* All chars printable, dump the packet as is */
389 LOG_DEBUG("received packet: %s", packet
);
393 static void gdb_log_outgoing_packet(char *packet_buf
, unsigned int packet_len
, unsigned char checksum
)
395 if (!LOG_LEVEL_IS(LOG_LVL_DEBUG
))
398 if (find_nonprint_char(packet_buf
, packet_len
))
399 LOG_DEBUG("sending packet: $<binary-data-%u-bytes>#%2.2x", packet_len
, checksum
);
401 LOG_DEBUG("sending packet: $%.*s#%2.2x'", packet_len
, packet_buf
, checksum
);
404 static int gdb_put_packet_inner(struct connection
*connection
,
405 char *buffer
, int len
)
408 unsigned char my_checksum
= 0;
411 struct gdb_connection
*gdb_con
= connection
->priv
;
413 for (i
= 0; i
< len
; i
++)
414 my_checksum
+= buffer
[i
];
416 #ifdef _DEBUG_GDB_IO_
418 * At this point we should have nothing in the input queue from GDB,
419 * however sometimes '-' is sent even though we've already received
420 * an ACK (+) for everything we've sent off.
424 retval
= check_pending(connection
, 0, &gotdata
);
425 if (retval
!= ERROR_OK
)
429 retval
= gdb_get_char(connection
, &reply
);
430 if (retval
!= ERROR_OK
)
433 /* fix a problem with some IAR tools */
434 gdb_putback_char(connection
, reply
);
435 LOG_DEBUG("Unexpected start of new packet");
439 LOG_WARNING("Discard unexpected char %c", reply
);
444 gdb_log_outgoing_packet(buffer
, len
, my_checksum
);
446 char local_buffer
[1024];
447 local_buffer
[0] = '$';
448 if ((size_t)len
+ 4 <= sizeof(local_buffer
)) {
449 /* performance gain on smaller packets by only a single call to gdb_write() */
450 memcpy(local_buffer
+ 1, buffer
, len
++);
451 len
+= snprintf(local_buffer
+ len
, sizeof(local_buffer
) - len
, "#%02x", my_checksum
);
452 retval
= gdb_write(connection
, local_buffer
, len
);
453 if (retval
!= ERROR_OK
)
456 /* larger packets are transmitted directly from caller supplied buffer
457 * by several calls to gdb_write() to avoid dynamic allocation */
458 snprintf(local_buffer
+ 1, sizeof(local_buffer
) - 1, "#%02x", my_checksum
);
459 retval
= gdb_write(connection
, local_buffer
, 1);
460 if (retval
!= ERROR_OK
)
462 retval
= gdb_write(connection
, buffer
, len
);
463 if (retval
!= ERROR_OK
)
465 retval
= gdb_write(connection
, local_buffer
+ 1, 3);
466 if (retval
!= ERROR_OK
)
470 if (gdb_con
->noack_mode
)
473 retval
= gdb_get_char(connection
, &reply
);
474 if (retval
!= ERROR_OK
)
479 else if (reply
== '-') {
480 /* Stop sending output packets for now */
481 log_remove_callback(gdb_log_callback
, connection
);
482 LOG_WARNING("negative reply, retrying");
483 } else if (reply
== 0x3) {
484 gdb_con
->ctrl_c
= true;
485 retval
= gdb_get_char(connection
, &reply
);
486 if (retval
!= ERROR_OK
)
490 else if (reply
== '-') {
491 /* Stop sending output packets for now */
492 log_remove_callback(gdb_log_callback
, connection
);
493 LOG_WARNING("negative reply, retrying");
494 } else if (reply
== '$') {
495 LOG_ERROR("GDB missing ack(1) - assumed good");
496 gdb_putback_char(connection
, reply
);
499 LOG_ERROR("unknown character(1) 0x%2.2x in reply, dropping connection", reply
);
500 gdb_con
->closed
= true;
501 return ERROR_SERVER_REMOTE_CLOSED
;
503 } else if (reply
== '$') {
504 LOG_ERROR("GDB missing ack(2) - assumed good");
505 gdb_putback_char(connection
, reply
);
508 LOG_ERROR("unknown character(2) 0x%2.2x in reply, dropping connection",
510 gdb_con
->closed
= true;
511 return ERROR_SERVER_REMOTE_CLOSED
;
515 return ERROR_SERVER_REMOTE_CLOSED
;
520 int gdb_put_packet(struct connection
*connection
, char *buffer
, int len
)
522 struct gdb_connection
*gdb_con
= connection
->priv
;
523 gdb_con
->busy
= true;
524 int retval
= gdb_put_packet_inner(connection
, buffer
, len
);
525 gdb_con
->busy
= false;
527 /* we sent some data, reset timer for keep alive messages */
533 static inline int fetch_packet(struct connection
*connection
,
534 int *checksum_ok
, int noack
, int *len
, char *buffer
)
536 unsigned char my_checksum
= 0;
539 int retval
= ERROR_OK
;
541 struct gdb_connection
*gdb_con
= connection
->priv
;
546 /* move this over into local variables to use registers and give the
547 * more freedom to optimize */
548 char *buf_p
= gdb_con
->buf_p
;
549 int buf_cnt
= gdb_con
->buf_cnt
;
552 /* The common case is that we have an entire packet with no escape chars.
553 * We need to leave at least 2 bytes in the buffer to have
554 * gdb_get_char() update various bits and bobs correctly.
556 if ((buf_cnt
> 2) && ((buf_cnt
+ count
) < *len
)) {
557 /* The compiler will struggle a bit with constant propagation and
558 * aliasing, so we help it by showing that these values do not
559 * change inside the loop
563 int run
= buf_cnt
- 2;
569 if (character
== '#') {
570 /* Danger! character can be '#' when esc is
571 * used so we need an explicit boolean for done here. */
576 if (character
== '}') {
577 /* data transmitted in binary mode (X packet)
578 * uses 0x7d as escape character */
579 my_checksum
+= character
& 0xff;
582 my_checksum
+= character
& 0xff;
583 buffer
[count
++] = (character
^ 0x20) & 0xff;
585 my_checksum
+= character
& 0xff;
586 buffer
[count
++] = character
& 0xff;
595 LOG_ERROR("packet buffer too small");
596 retval
= ERROR_GDB_BUFFER_TOO_SMALL
;
600 retval
= gdb_get_char_fast(connection
, &character
, &buf_p
, &buf_cnt
);
601 if (retval
!= ERROR_OK
)
604 if (character
== '#')
607 if (character
== '}') {
608 /* data transmitted in binary mode (X packet)
609 * uses 0x7d as escape character */
610 my_checksum
+= character
& 0xff;
612 retval
= gdb_get_char_fast(connection
, &character
, &buf_p
, &buf_cnt
);
613 if (retval
!= ERROR_OK
)
616 my_checksum
+= character
& 0xff;
617 buffer
[count
++] = (character
^ 0x20) & 0xff;
619 my_checksum
+= character
& 0xff;
620 buffer
[count
++] = character
& 0xff;
624 gdb_con
->buf_p
= buf_p
;
625 gdb_con
->buf_cnt
= buf_cnt
;
627 if (retval
!= ERROR_OK
)
632 retval
= gdb_get_char(connection
, &character
);
633 if (retval
!= ERROR_OK
)
635 checksum
[0] = character
;
636 retval
= gdb_get_char(connection
, &character
);
637 if (retval
!= ERROR_OK
)
639 checksum
[1] = character
;
643 *checksum_ok
= (my_checksum
== strtoul(checksum
, NULL
, 16));
648 static int gdb_get_packet_inner(struct connection
*connection
,
649 char *buffer
, int *len
)
653 struct gdb_connection
*gdb_con
= connection
->priv
;
657 retval
= gdb_get_char(connection
, &character
);
658 if (retval
!= ERROR_OK
)
661 #ifdef _DEBUG_GDB_IO_
662 LOG_DEBUG("character: '%c'", character
);
669 /* According to the GDB documentation
670 * (https://sourceware.org/gdb/onlinedocs/gdb/Packet-Acknowledgment.html):
671 * "gdb sends a final `+` acknowledgment of the stub's `OK`
672 * response, which can be safely ignored by the stub."
673 * However OpenOCD server already is in noack mode at this
674 * point and instead of ignoring this it was emitting a
675 * warning. This code makes server ignore the first ACK
676 * that will be received after going into noack mode,
677 * warning only about subsequent ACK's. */
678 if (gdb_con
->noack_mode
> 1) {
679 LOG_WARNING("acknowledgment received, but no packet pending");
680 } else if (gdb_con
->noack_mode
) {
681 LOG_DEBUG("Received first acknowledgment after entering noack mode. Ignoring it.");
682 gdb_con
->noack_mode
= 2;
686 LOG_WARNING("negative acknowledgment, but no packet pending");
689 gdb_con
->ctrl_c
= true;
693 LOG_WARNING("ignoring character 0x%x", character
);
696 } while (character
!= '$');
699 /* explicit code expansion here to get faster inlined code in -O3 by not
700 * calculating checksum */
701 if (gdb_con
->noack_mode
) {
702 retval
= fetch_packet(connection
, &checksum_ok
, 1, len
, buffer
);
703 if (retval
!= ERROR_OK
)
706 retval
= fetch_packet(connection
, &checksum_ok
, 0, len
, buffer
);
707 if (retval
!= ERROR_OK
)
711 if (gdb_con
->noack_mode
) {
712 /* checksum is not checked in noack mode */
716 retval
= gdb_write(connection
, "+", 1);
717 if (retval
!= ERROR_OK
)
723 return ERROR_SERVER_REMOTE_CLOSED
;
728 static int gdb_get_packet(struct connection
*connection
, char *buffer
, int *len
)
730 struct gdb_connection
*gdb_con
= connection
->priv
;
731 gdb_con
->busy
= true;
732 int retval
= gdb_get_packet_inner(connection
, buffer
, len
);
733 gdb_con
->busy
= false;
737 static int gdb_output_con(struct connection
*connection
, const char *line
)
742 bin_size
= strlen(line
);
744 hex_buffer
= malloc(bin_size
* 2 + 2);
746 return ERROR_GDB_BUFFER_TOO_SMALL
;
749 size_t pkt_len
= hexify(hex_buffer
+ 1, (const uint8_t *)line
, bin_size
,
751 int retval
= gdb_put_packet(connection
, hex_buffer
, pkt_len
+ 1);
757 static int gdb_output(struct command_context
*context
, const char *line
)
759 /* this will be dumped to the log and also sent as an O packet if possible */
760 LOG_USER_N("%s", line
);
764 static void gdb_signal_reply(struct target
*target
, struct connection
*connection
)
766 struct gdb_connection
*gdb_connection
= connection
->priv
;
768 char stop_reason
[32];
769 char current_thread
[25];
773 rtos_update_threads(target
);
775 if (target
->debug_reason
== DBG_REASON_EXIT
) {
776 sig_reply_len
= snprintf(sig_reply
, sizeof(sig_reply
), "W00");
780 target
->rtos
->current_threadid
= target
->rtos
->current_thread
;
781 target
->rtos
->gdb_target_for_threadid(connection
, target
->rtos
->current_threadid
, &ct
);
786 if (gdb_connection
->ctrl_c
) {
789 signal_var
= gdb_last_signal(ct
);
791 stop_reason
[0] = '\0';
792 if (ct
->debug_reason
== DBG_REASON_WATCHPOINT
) {
793 enum watchpoint_rw hit_wp_type
;
794 target_addr_t hit_wp_address
;
796 if (watchpoint_hit(ct
, &hit_wp_type
, &hit_wp_address
) == ERROR_OK
) {
798 switch (hit_wp_type
) {
800 snprintf(stop_reason
, sizeof(stop_reason
),
801 "watch:%08" TARGET_PRIxADDR
";", hit_wp_address
);
804 snprintf(stop_reason
, sizeof(stop_reason
),
805 "rwatch:%08" TARGET_PRIxADDR
";", hit_wp_address
);
808 snprintf(stop_reason
, sizeof(stop_reason
),
809 "awatch:%08" TARGET_PRIxADDR
";", hit_wp_address
);
817 current_thread
[0] = '\0';
819 snprintf(current_thread
, sizeof(current_thread
), "thread:%" PRIx64
";",
820 target
->rtos
->current_thread
);
822 sig_reply_len
= snprintf(sig_reply
, sizeof(sig_reply
), "T%2.2x%s%s",
823 signal_var
, stop_reason
, current_thread
);
825 gdb_connection
->ctrl_c
= false;
828 gdb_put_packet(connection
, sig_reply
, sig_reply_len
);
829 gdb_connection
->frontend_state
= TARGET_HALTED
;
832 static void gdb_fileio_reply(struct target
*target
, struct connection
*connection
)
834 struct gdb_connection
*gdb_connection
= connection
->priv
;
835 char fileio_command
[256];
837 bool program_exited
= false;
839 if (strcmp(target
->fileio_info
->identifier
, "open") == 0)
840 sprintf(fileio_command
, "F%s,%" PRIx64
"/%" PRIx64
",%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
841 target
->fileio_info
->param_1
,
842 target
->fileio_info
->param_2
+ 1, /* len + trailing zero */
843 target
->fileio_info
->param_3
,
844 target
->fileio_info
->param_4
);
845 else if (strcmp(target
->fileio_info
->identifier
, "close") == 0)
846 sprintf(fileio_command
, "F%s,%" PRIx64
, target
->fileio_info
->identifier
,
847 target
->fileio_info
->param_1
);
848 else if (strcmp(target
->fileio_info
->identifier
, "read") == 0)
849 sprintf(fileio_command
, "F%s,%" PRIx64
",%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
850 target
->fileio_info
->param_1
,
851 target
->fileio_info
->param_2
,
852 target
->fileio_info
->param_3
);
853 else if (strcmp(target
->fileio_info
->identifier
, "write") == 0)
854 sprintf(fileio_command
, "F%s,%" PRIx64
",%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
855 target
->fileio_info
->param_1
,
856 target
->fileio_info
->param_2
,
857 target
->fileio_info
->param_3
);
858 else if (strcmp(target
->fileio_info
->identifier
, "lseek") == 0)
859 sprintf(fileio_command
, "F%s,%" PRIx64
",%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
860 target
->fileio_info
->param_1
,
861 target
->fileio_info
->param_2
,
862 target
->fileio_info
->param_3
);
863 else if (strcmp(target
->fileio_info
->identifier
, "rename") == 0)
864 sprintf(fileio_command
, "F%s,%" PRIx64
"/%" PRIx64
",%" PRIx64
"/%" PRIx64
, target
->fileio_info
->identifier
,
865 target
->fileio_info
->param_1
,
866 target
->fileio_info
->param_2
+ 1, /* len + trailing zero */
867 target
->fileio_info
->param_3
,
868 target
->fileio_info
->param_4
+ 1); /* len + trailing zero */
869 else if (strcmp(target
->fileio_info
->identifier
, "unlink") == 0)
870 sprintf(fileio_command
, "F%s,%" PRIx64
"/%" PRIx64
, target
->fileio_info
->identifier
,
871 target
->fileio_info
->param_1
,
872 target
->fileio_info
->param_2
+ 1); /* len + trailing zero */
873 else if (strcmp(target
->fileio_info
->identifier
, "stat") == 0)
874 sprintf(fileio_command
, "F%s,%" PRIx64
"/%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
875 target
->fileio_info
->param_1
,
876 target
->fileio_info
->param_2
,
877 target
->fileio_info
->param_3
);
878 else if (strcmp(target
->fileio_info
->identifier
, "fstat") == 0)
879 sprintf(fileio_command
, "F%s,%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
880 target
->fileio_info
->param_1
,
881 target
->fileio_info
->param_2
);
882 else if (strcmp(target
->fileio_info
->identifier
, "gettimeofday") == 0)
883 sprintf(fileio_command
, "F%s,%" PRIx64
",%" PRIx64
, target
->fileio_info
->identifier
,
884 target
->fileio_info
->param_1
,
885 target
->fileio_info
->param_2
);
886 else if (strcmp(target
->fileio_info
->identifier
, "isatty") == 0)
887 sprintf(fileio_command
, "F%s,%" PRIx64
, target
->fileio_info
->identifier
,
888 target
->fileio_info
->param_1
);
889 else if (strcmp(target
->fileio_info
->identifier
, "system") == 0)
890 sprintf(fileio_command
, "F%s,%" PRIx64
"/%" PRIx64
, target
->fileio_info
->identifier
,
891 target
->fileio_info
->param_1
,
892 target
->fileio_info
->param_2
+ 1); /* len + trailing zero */
893 else if (strcmp(target
->fileio_info
->identifier
, "exit") == 0) {
894 /* If target hits exit syscall, report to GDB the program is terminated.
895 * In addition, let target run its own exit syscall handler. */
896 program_exited
= true;
897 sprintf(fileio_command
, "W%02" PRIx64
, target
->fileio_info
->param_1
);
899 LOG_DEBUG("Unknown syscall: %s", target
->fileio_info
->identifier
);
901 /* encounter unknown syscall, continue */
902 gdb_connection
->frontend_state
= TARGET_RUNNING
;
903 target_resume(target
, 1, 0x0, 0, 0);
907 command_len
= strlen(fileio_command
);
908 gdb_put_packet(connection
, fileio_command
, command_len
);
910 if (program_exited
) {
911 /* Use target_resume() to let target run its own exit syscall handler. */
912 gdb_connection
->frontend_state
= TARGET_RUNNING
;
913 target_resume(target
, 1, 0x0, 0, 0);
915 gdb_connection
->frontend_state
= TARGET_HALTED
;
916 rtos_update_threads(target
);
920 static void gdb_frontend_halted(struct target
*target
, struct connection
*connection
)
922 struct gdb_connection
*gdb_connection
= connection
->priv
;
924 /* In the GDB protocol when we are stepping or continuing execution,
925 * we have a lingering reply. Upon receiving a halted event
926 * when we have that lingering packet, we reply to the original
927 * step or continue packet.
929 * Executing monitor commands can bring the target in and
930 * out of the running state so we'll see lots of TARGET_EVENT_XXX
931 * that are to be ignored.
933 if (gdb_connection
->frontend_state
== TARGET_RUNNING
) {
934 /* stop forwarding log packets! */
935 log_remove_callback(gdb_log_callback
, connection
);
937 /* check fileio first */
938 if (target_get_gdb_fileio_info(target
, target
->fileio_info
) == ERROR_OK
)
939 gdb_fileio_reply(target
, connection
);
941 gdb_signal_reply(target
, connection
);
945 static int gdb_target_callback_event_handler(struct target
*target
,
946 enum target_event event
, void *priv
)
948 struct connection
*connection
= priv
;
949 struct gdb_service
*gdb_service
= connection
->service
->priv
;
951 if (gdb_service
->target
!= target
)
955 case TARGET_EVENT_GDB_HALT
:
956 gdb_frontend_halted(target
, connection
);
958 case TARGET_EVENT_HALTED
:
959 target_call_event_callbacks(target
, TARGET_EVENT_GDB_END
);
968 static int gdb_new_connection(struct connection
*connection
)
970 struct gdb_connection
*gdb_connection
= malloc(sizeof(struct gdb_connection
));
971 struct target
*target
;
975 target
= get_target_from_connection(connection
);
976 connection
->priv
= gdb_connection
;
977 connection
->cmd_ctx
->current_target
= target
;
979 /* initialize gdb connection information */
980 gdb_connection
->buf_p
= gdb_connection
->buffer
;
981 gdb_connection
->buf_cnt
= 0;
982 gdb_connection
->ctrl_c
= false;
983 gdb_connection
->frontend_state
= TARGET_HALTED
;
984 gdb_connection
->vflash_image
= NULL
;
985 gdb_connection
->closed
= false;
986 gdb_connection
->busy
= false;
987 gdb_connection
->noack_mode
= 0;
988 gdb_connection
->sync
= false;
989 gdb_connection
->mem_write_error
= false;
990 gdb_connection
->attached
= true;
991 gdb_connection
->extended_protocol
= false;
992 gdb_connection
->target_desc
.tdesc
= NULL
;
993 gdb_connection
->target_desc
.tdesc_length
= 0;
994 gdb_connection
->thread_list
= NULL
;
996 /* send ACK to GDB for debug request */
997 gdb_write(connection
, "+", 1);
999 /* output goes through gdb connection */
1000 command_set_output_handler(connection
->cmd_ctx
, gdb_output
, connection
);
1002 /* we must remove all breakpoints registered to the target as a previous
1003 * GDB session could leave dangling breakpoints if e.g. communication
1006 breakpoint_clear_target(target
);
1007 watchpoint_clear_target(target
);
1009 /* Since version 3.95 (gdb-19990504), with the exclusion of 6.5~6.8, GDB
1010 * sends an ACK at connection with the following comment in its source code:
1011 * "Ack any packet which the remote side has already sent."
1012 * LLDB does the same since the first gdb-remote implementation.
1013 * Remove the initial ACK from the incoming buffer.
1015 retval
= gdb_get_char(connection
, &initial_ack
);
1016 if (retval
!= ERROR_OK
)
1019 if (initial_ack
!= '+')
1020 gdb_putback_char(connection
, initial_ack
);
1022 target_call_event_callbacks(target
, TARGET_EVENT_GDB_ATTACH
);
1025 /* clean previous rtos session if supported*/
1026 if (target
->rtos
->type
->clean
)
1027 target
->rtos
->type
->clean(target
);
1029 /* update threads */
1030 rtos_update_threads(target
);
1033 if (gdb_use_memory_map
) {
1034 /* Connect must fail if the memory map can't be set up correctly.
1036 * This will cause an auto_probe to be invoked, which is either
1037 * a no-op or it will fail when the target isn't ready(e.g. not halted).
1039 for (unsigned int i
= 0; i
< flash_get_bank_count(); i
++) {
1040 struct flash_bank
*p
;
1041 p
= get_flash_bank_by_num_noprobe(i
);
1042 if (p
->target
!= target
)
1044 retval
= get_flash_bank_by_num(i
, &p
);
1045 if (retval
!= ERROR_OK
) {
1046 LOG_ERROR("Connect failed. Consider setting up a gdb-attach event for the target "
1047 "to prepare target for GDB connect, or use 'gdb_memory_map disable'.");
1053 gdb_actual_connections
++;
1054 log_printf_lf(all_targets
->next
? LOG_LVL_INFO
: LOG_LVL_DEBUG
,
1055 __FILE__
, __LINE__
, __func__
,
1056 "New GDB Connection: %d, Target %s, state: %s",
1057 gdb_actual_connections
,
1058 target_name(target
),
1059 target_state_name(target
));
1061 if (!target_was_examined(target
)) {
1062 LOG_ERROR("Target %s not examined yet, refuse gdb connection %d!",
1063 target_name(target
), gdb_actual_connections
);
1064 gdb_actual_connections
--;
1065 return ERROR_TARGET_NOT_EXAMINED
;
1068 if (target
->state
!= TARGET_HALTED
)
1069 LOG_WARNING("GDB connection %d on target %s not halted",
1070 gdb_actual_connections
, target_name(target
));
1072 /* DANGER! If we fail subsequently, we must remove this handler,
1073 * otherwise we occasionally see crashes as the timer can invoke the
1076 * register callback to be informed about target events */
1077 target_register_event_callback(gdb_target_callback_event_handler
, connection
);
1082 static int gdb_connection_closed(struct connection
*connection
)
1084 struct target
*target
;
1085 struct gdb_connection
*gdb_connection
= connection
->priv
;
1087 target
= get_target_from_connection(connection
);
1089 /* we're done forwarding messages. Tear down callback before
1090 * cleaning up connection.
1092 log_remove_callback(gdb_log_callback
, connection
);
1094 gdb_actual_connections
--;
1095 LOG_DEBUG("GDB Close, Target: %s, state: %s, gdb_actual_connections=%d",
1096 target_name(target
),
1097 target_state_name(target
),
1098 gdb_actual_connections
);
1100 /* see if an image built with vFlash commands is left */
1101 if (gdb_connection
->vflash_image
) {
1102 image_close(gdb_connection
->vflash_image
);
1103 free(gdb_connection
->vflash_image
);
1104 gdb_connection
->vflash_image
= NULL
;
1107 /* if this connection registered a debug-message receiver delete it */
1108 delete_debug_msg_receiver(connection
->cmd_ctx
, target
);
1110 free(connection
->priv
);
1111 connection
->priv
= NULL
;
1113 target_unregister_event_callback(gdb_target_callback_event_handler
, connection
);
1115 target_call_event_callbacks(target
, TARGET_EVENT_GDB_END
);
1117 target_call_event_callbacks(target
, TARGET_EVENT_GDB_DETACH
);
1122 static void gdb_send_error(struct connection
*connection
, uint8_t the_error
)
1125 snprintf(err
, 4, "E%2.2X", the_error
);
1126 gdb_put_packet(connection
, err
, 3);
1129 static int gdb_last_signal_packet(struct connection
*connection
,
1130 char const *packet
, int packet_size
)
1132 struct target
*target
= get_target_from_connection(connection
);
1133 struct gdb_connection
*gdb_con
= connection
->priv
;
1137 if (!gdb_con
->attached
) {
1138 /* if we are here we have received a kill packet
1139 * reply W stop reply otherwise gdb gets very unhappy */
1140 gdb_put_packet(connection
, "W00", 3);
1144 signal_var
= gdb_last_signal(target
);
1146 snprintf(sig_reply
, 4, "S%2.2x", signal_var
);
1147 gdb_put_packet(connection
, sig_reply
, 3);
1152 static inline int gdb_reg_pos(struct target
*target
, int pos
, int len
)
1154 if (target
->endianness
== TARGET_LITTLE_ENDIAN
)
1157 return len
- 1 - pos
;
1160 /* Convert register to string of bytes. NB! The # of bits in the
1161 * register might be non-divisible by 8(a byte), in which
1162 * case an entire byte is shown.
1164 * NB! the format on the wire is the target endianness
1166 * The format of reg->value is little endian
1169 static void gdb_str_to_target(struct target
*target
,
1170 char *tstr
, struct reg
*reg
)
1177 buf_len
= DIV_ROUND_UP(reg
->size
, 8);
1179 for (i
= 0; i
< buf_len
; i
++) {
1180 int j
= gdb_reg_pos(target
, i
, buf_len
);
1181 tstr
+= sprintf(tstr
, "%02x", buf
[j
]);
1185 /* copy over in register buffer */
1186 static void gdb_target_to_reg(struct target
*target
,
1187 char const *tstr
, int str_len
, uint8_t *bin
)
1190 LOG_ERROR("BUG: gdb value with uneven number of characters encountered");
1195 for (i
= 0; i
< str_len
; i
+= 2) {
1197 if (sscanf(tstr
+ i
, "%02x", &t
) != 1) {
1198 LOG_ERROR("BUG: unable to convert register value");
1202 int j
= gdb_reg_pos(target
, i
/2, str_len
/2);
1207 static int gdb_get_registers_packet(struct connection
*connection
,
1208 char const *packet
, int packet_size
)
1210 struct target
*target
= get_target_from_connection(connection
);
1211 struct reg
**reg_list
;
1214 int reg_packet_size
= 0;
1219 #ifdef _DEBUG_GDB_IO_
1223 if ((target
->rtos
) && (rtos_get_gdb_reg_list(connection
) == ERROR_OK
))
1226 retval
= target_get_gdb_reg_list(target
, ®_list
, ®_list_size
,
1228 if (retval
!= ERROR_OK
)
1229 return gdb_error(connection
, retval
);
1231 for (i
= 0; i
< reg_list_size
; i
++) {
1232 if (!reg_list
[i
] || reg_list
[i
]->exist
== false || reg_list
[i
]->hidden
)
1234 reg_packet_size
+= DIV_ROUND_UP(reg_list
[i
]->size
, 8) * 2;
1237 assert(reg_packet_size
> 0);
1239 reg_packet
= malloc(reg_packet_size
+ 1); /* plus one for string termination null */
1243 reg_packet_p
= reg_packet
;
1245 for (i
= 0; i
< reg_list_size
; i
++) {
1246 if (!reg_list
[i
] || reg_list
[i
]->exist
== false || reg_list
[i
]->hidden
)
1248 if (!reg_list
[i
]->valid
) {
1249 retval
= reg_list
[i
]->type
->get(reg_list
[i
]);
1250 if (retval
!= ERROR_OK
&& gdb_report_register_access_error
) {
1251 LOG_DEBUG("Couldn't get register %s.", reg_list
[i
]->name
);
1254 return gdb_error(connection
, retval
);
1257 gdb_str_to_target(target
, reg_packet_p
, reg_list
[i
]);
1258 reg_packet_p
+= DIV_ROUND_UP(reg_list
[i
]->size
, 8) * 2;
1261 #ifdef _DEBUG_GDB_IO_
1263 char *reg_packet_p_debug
;
1264 reg_packet_p_debug
= strndup(reg_packet
, reg_packet_size
);
1265 LOG_DEBUG("reg_packet: %s", reg_packet_p_debug
);
1266 free(reg_packet_p_debug
);
1270 gdb_put_packet(connection
, reg_packet
, reg_packet_size
);
1278 static int gdb_set_registers_packet(struct connection
*connection
,
1279 char const *packet
, int packet_size
)
1281 struct target
*target
= get_target_from_connection(connection
);
1283 struct reg
**reg_list
;
1286 char const *packet_p
;
1288 #ifdef _DEBUG_GDB_IO_
1292 /* skip command character */
1296 if (packet_size
% 2) {
1297 LOG_WARNING("GDB set_registers packet with uneven characters received, dropping connection");
1298 return ERROR_SERVER_REMOTE_CLOSED
;
1301 retval
= target_get_gdb_reg_list(target
, ®_list
, ®_list_size
,
1303 if (retval
!= ERROR_OK
)
1304 return gdb_error(connection
, retval
);
1307 for (i
= 0; i
< reg_list_size
; i
++) {
1309 int chars
= (DIV_ROUND_UP(reg_list
[i
]->size
, 8) * 2);
1311 if (packet_p
+ chars
> packet
+ packet_size
)
1312 LOG_ERROR("BUG: register packet is too small for registers");
1314 bin_buf
= malloc(DIV_ROUND_UP(reg_list
[i
]->size
, 8));
1315 gdb_target_to_reg(target
, packet_p
, chars
, bin_buf
);
1317 retval
= reg_list
[i
]->type
->set(reg_list
[i
], bin_buf
);
1318 if (retval
!= ERROR_OK
&& gdb_report_register_access_error
) {
1319 LOG_DEBUG("Couldn't set register %s.", reg_list
[i
]->name
);
1322 return gdb_error(connection
, retval
);
1325 /* advance packet pointer */
1331 /* free struct reg *reg_list[] array allocated by get_gdb_reg_list */
1334 gdb_put_packet(connection
, "OK", 2);
1339 static int gdb_get_register_packet(struct connection
*connection
,
1340 char const *packet
, int packet_size
)
1342 struct target
*target
= get_target_from_connection(connection
);
1344 int reg_num
= strtoul(packet
+ 1, NULL
, 16);
1345 struct reg
**reg_list
;
1349 #ifdef _DEBUG_GDB_IO_
1353 if ((target
->rtos
) && (rtos_get_gdb_reg(connection
, reg_num
) == ERROR_OK
))
1356 retval
= target_get_gdb_reg_list_noread(target
, ®_list
, ®_list_size
,
1358 if (retval
!= ERROR_OK
)
1359 return gdb_error(connection
, retval
);
1361 if (reg_list_size
<= reg_num
) {
1362 LOG_ERROR("gdb requested a non-existing register (reg_num=%d)", reg_num
);
1363 return ERROR_SERVER_REMOTE_CLOSED
;
1366 if (!reg_list
[reg_num
]->valid
) {
1367 retval
= reg_list
[reg_num
]->type
->get(reg_list
[reg_num
]);
1368 if (retval
!= ERROR_OK
&& gdb_report_register_access_error
) {
1369 LOG_DEBUG("Couldn't get register %s.", reg_list
[reg_num
]->name
);
1371 return gdb_error(connection
, retval
);
1375 reg_packet
= calloc(DIV_ROUND_UP(reg_list
[reg_num
]->size
, 8) * 2 + 1, 1); /* plus one for string termination null */
1377 gdb_str_to_target(target
, reg_packet
, reg_list
[reg_num
]);
1379 gdb_put_packet(connection
, reg_packet
, DIV_ROUND_UP(reg_list
[reg_num
]->size
, 8) * 2);
1387 static int gdb_set_register_packet(struct connection
*connection
,
1388 char const *packet
, int packet_size
)
1390 struct target
*target
= get_target_from_connection(connection
);
1392 int reg_num
= strtoul(packet
+ 1, &separator
, 16);
1393 struct reg
**reg_list
;
1397 #ifdef _DEBUG_GDB_IO_
1401 if (*separator
!= '=') {
1402 LOG_ERROR("GDB 'set register packet', but no '=' following the register number");
1403 return ERROR_SERVER_REMOTE_CLOSED
;
1405 size_t chars
= strlen(separator
+ 1);
1406 uint8_t *bin_buf
= malloc(chars
/ 2);
1407 gdb_target_to_reg(target
, separator
+ 1, chars
, bin_buf
);
1409 if ((target
->rtos
) &&
1410 (rtos_set_reg(connection
, reg_num
, bin_buf
) == ERROR_OK
)) {
1412 gdb_put_packet(connection
, "OK", 2);
1416 retval
= target_get_gdb_reg_list_noread(target
, ®_list
, ®_list_size
,
1418 if (retval
!= ERROR_OK
) {
1420 return gdb_error(connection
, retval
);
1423 if (reg_list_size
<= reg_num
) {
1424 LOG_ERROR("gdb requested a non-existing register (reg_num=%d)", reg_num
);
1427 return ERROR_SERVER_REMOTE_CLOSED
;
1430 if (chars
!= (DIV_ROUND_UP(reg_list
[reg_num
]->size
, 8) * 2)) {
1431 LOG_ERROR("gdb sent %zu bits for a %" PRIu32
"-bit register (%s)",
1432 chars
* 4, reg_list
[reg_num
]->size
, reg_list
[reg_num
]->name
);
1435 return ERROR_SERVER_REMOTE_CLOSED
;
1438 gdb_target_to_reg(target
, separator
+ 1, chars
, bin_buf
);
1440 retval
= reg_list
[reg_num
]->type
->set(reg_list
[reg_num
], bin_buf
);
1441 if (retval
!= ERROR_OK
&& gdb_report_register_access_error
) {
1442 LOG_DEBUG("Couldn't set register %s.", reg_list
[reg_num
]->name
);
1445 return gdb_error(connection
, retval
);
1448 gdb_put_packet(connection
, "OK", 2);
1456 /* No attempt is made to translate the "retval" to
1457 * GDB speak. This has to be done at the calling
1458 * site as no mapping really exists.
1460 static int gdb_error(struct connection
*connection
, int retval
)
1462 LOG_DEBUG("Reporting %i to GDB as generic error", retval
);
1463 gdb_send_error(connection
, EFAULT
);
1467 /* We don't have to worry about the default 2 second timeout for GDB packets,
1468 * because GDB breaks up large memory reads into smaller reads.
1470 static int gdb_read_memory_packet(struct connection
*connection
,
1471 char const *packet
, int packet_size
)
1473 struct target
*target
= get_target_from_connection(connection
);
1481 int retval
= ERROR_OK
;
1483 /* skip command character */
1486 addr
= strtoull(packet
, &separator
, 16);
1488 if (*separator
!= ',') {
1489 LOG_ERROR("incomplete read memory packet received, dropping connection");
1490 return ERROR_SERVER_REMOTE_CLOSED
;
1493 len
= strtoul(separator
+ 1, NULL
, 16);
1496 LOG_WARNING("invalid read memory packet received (len == 0)");
1497 gdb_put_packet(connection
, "", 0);
1501 buffer
= malloc(len
);
1503 LOG_DEBUG("addr: 0x%16.16" PRIx64
", len: 0x%8.8" PRIx32
"", addr
, len
);
1505 retval
= ERROR_NOT_IMPLEMENTED
;
1507 retval
= rtos_read_buffer(target
, addr
, len
, buffer
);
1508 if (retval
== ERROR_NOT_IMPLEMENTED
)
1509 retval
= target_read_buffer(target
, addr
, len
, buffer
);
1511 if ((retval
!= ERROR_OK
) && !gdb_report_data_abort
) {
1512 /* TODO : Here we have to lie and send back all zero's lest stack traces won't work.
1513 * At some point this might be fixed in GDB, in which case this code can be removed.
1515 * OpenOCD developers are acutely aware of this problem, but there is nothing
1516 * gained by involving the user in this problem that hopefully will get resolved
1519 * http://sourceware.org/cgi-bin/gnatsweb.pl? \
1520 * cmd = view%20audit-trail&database = gdb&pr = 2395
1522 * For now, the default is to fix up things to make current GDB versions work.
1523 * This can be overwritten using the gdb_report_data_abort <'enable'|'disable'> command.
1525 memset(buffer
, 0, len
);
1529 if (retval
== ERROR_OK
) {
1530 hex_buffer
= malloc(len
* 2 + 1);
1532 size_t pkt_len
= hexify(hex_buffer
, buffer
, len
, len
* 2 + 1);
1534 gdb_put_packet(connection
, hex_buffer
, pkt_len
);
1538 retval
= gdb_error(connection
, retval
);
1545 static int gdb_write_memory_packet(struct connection
*connection
,
1546 char const *packet
, int packet_size
)
1548 struct target
*target
= get_target_from_connection(connection
);
1556 /* skip command character */
1559 addr
= strtoull(packet
, &separator
, 16);
1561 if (*separator
!= ',') {
1562 LOG_ERROR("incomplete write memory packet received, dropping connection");
1563 return ERROR_SERVER_REMOTE_CLOSED
;
1566 len
= strtoul(separator
+ 1, &separator
, 16);
1568 if (*(separator
++) != ':') {
1569 LOG_ERROR("incomplete write memory packet received, dropping connection");
1570 return ERROR_SERVER_REMOTE_CLOSED
;
1573 buffer
= malloc(len
);
1575 LOG_DEBUG("addr: 0x%" PRIx64
", len: 0x%8.8" PRIx32
"", addr
, len
);
1577 if (unhexify(buffer
, separator
, len
) != len
)
1578 LOG_ERROR("unable to decode memory packet");
1580 retval
= ERROR_NOT_IMPLEMENTED
;
1582 retval
= rtos_write_buffer(target
, addr
, len
, buffer
);
1583 if (retval
== ERROR_NOT_IMPLEMENTED
)
1584 retval
= target_write_buffer(target
, addr
, len
, buffer
);
1586 if (retval
== ERROR_OK
)
1587 gdb_put_packet(connection
, "OK", 2);
1589 retval
= gdb_error(connection
, retval
);
1596 static int gdb_write_memory_binary_packet(struct connection
*connection
,
1597 char const *packet
, int packet_size
)
1599 struct target
*target
= get_target_from_connection(connection
);
1604 int retval
= ERROR_OK
;
1605 /* Packets larger than fast_limit bytes will be acknowledged instantly on
1606 * the assumption that we're in a download and it's important to go as fast
1608 uint32_t fast_limit
= 8;
1610 /* skip command character */
1613 addr
= strtoull(packet
, &separator
, 16);
1615 if (*separator
!= ',') {
1616 LOG_ERROR("incomplete write memory binary packet received, dropping connection");
1617 return ERROR_SERVER_REMOTE_CLOSED
;
1620 len
= strtoul(separator
+ 1, &separator
, 16);
1622 if (*(separator
++) != ':') {
1623 LOG_ERROR("incomplete write memory binary packet received, dropping connection");
1624 return ERROR_SERVER_REMOTE_CLOSED
;
1627 struct gdb_connection
*gdb_connection
= connection
->priv
;
1629 if (gdb_connection
->mem_write_error
)
1630 retval
= ERROR_FAIL
;
1632 if (retval
== ERROR_OK
) {
1633 if (len
>= fast_limit
) {
1634 /* By replying the packet *immediately* GDB will send us a new packet
1635 * while we write the last one to the target.
1636 * We only do this for larger writes, so that users who do something like:
1637 * p *((int*)0xdeadbeef)=8675309
1638 * will get immediate feedback that that write failed.
1640 gdb_put_packet(connection
, "OK", 2);
1643 retval
= gdb_error(connection
, retval
);
1644 /* now that we have reported the memory write error, we can clear the condition */
1645 gdb_connection
->mem_write_error
= false;
1646 if (retval
!= ERROR_OK
)
1651 LOG_DEBUG("addr: 0x%" PRIx64
", len: 0x%8.8" PRIx32
"", addr
, len
);
1653 retval
= ERROR_NOT_IMPLEMENTED
;
1655 retval
= rtos_write_buffer(target
, addr
, len
, (uint8_t *)separator
);
1656 if (retval
== ERROR_NOT_IMPLEMENTED
)
1657 retval
= target_write_buffer(target
, addr
, len
, (uint8_t *)separator
);
1659 if (retval
!= ERROR_OK
)
1660 gdb_connection
->mem_write_error
= true;
1663 if (len
< fast_limit
) {
1664 if (retval
!= ERROR_OK
) {
1665 gdb_error(connection
, retval
);
1666 gdb_connection
->mem_write_error
= false;
1668 gdb_put_packet(connection
, "OK", 2);
1675 static int gdb_step_continue_packet(struct connection
*connection
,
1676 char const *packet
, int packet_size
)
1678 struct target
*target
= get_target_from_connection(connection
);
1680 uint64_t address
= 0x0;
1681 int retval
= ERROR_OK
;
1685 if (packet_size
> 1)
1686 address
= strtoull(packet
+ 1, NULL
, 16);
1690 gdb_running_type
= packet
[0];
1691 if (packet
[0] == 'c') {
1692 LOG_DEBUG("continue");
1693 /* resume at current address, don't handle breakpoints, not debugging */
1694 retval
= target_resume(target
, current
, address
, 0, 0);
1695 } else if (packet
[0] == 's') {
1697 /* step at current or address, don't handle breakpoints */
1698 retval
= target_step(target
, current
, address
, 0);
1703 static int gdb_breakpoint_watchpoint_packet(struct connection
*connection
,
1704 char const *packet
, int packet_size
)
1706 struct target
*target
= get_target_from_connection(connection
);
1708 enum breakpoint_type bp_type
= BKPT_SOFT
/* dummy init to avoid warning */;
1709 enum watchpoint_rw wp_type
= WPT_READ
/* dummy init to avoid warning */;
1715 LOG_DEBUG("[%s]", target_name(target
));
1717 type
= strtoul(packet
+ 1, &separator
, 16);
1719 if (type
== 0) /* memory breakpoint */
1720 bp_type
= BKPT_SOFT
;
1721 else if (type
== 1) /* hardware breakpoint */
1722 bp_type
= BKPT_HARD
;
1723 else if (type
== 2) /* write watchpoint */
1724 wp_type
= WPT_WRITE
;
1725 else if (type
== 3) /* read watchpoint */
1727 else if (type
== 4) /* access watchpoint */
1728 wp_type
= WPT_ACCESS
;
1730 LOG_ERROR("invalid gdb watch/breakpoint type(%d), dropping connection", type
);
1731 return ERROR_SERVER_REMOTE_CLOSED
;
1734 if (gdb_breakpoint_override
&& ((bp_type
== BKPT_SOFT
) || (bp_type
== BKPT_HARD
)))
1735 bp_type
= gdb_breakpoint_override_type
;
1737 if (*separator
!= ',') {
1738 LOG_ERROR("incomplete breakpoint/watchpoint packet received, dropping connection");
1739 return ERROR_SERVER_REMOTE_CLOSED
;
1742 address
= strtoull(separator
+ 1, &separator
, 16);
1744 if (*separator
!= ',') {
1745 LOG_ERROR("incomplete breakpoint/watchpoint packet received, dropping connection");
1746 return ERROR_SERVER_REMOTE_CLOSED
;
1749 size
= strtoul(separator
+ 1, &separator
, 16);
1754 if (packet
[0] == 'Z') {
1755 retval
= breakpoint_add(target
, address
, size
, bp_type
);
1756 if (retval
!= ERROR_OK
) {
1757 retval
= gdb_error(connection
, retval
);
1758 if (retval
!= ERROR_OK
)
1761 gdb_put_packet(connection
, "OK", 2);
1763 breakpoint_remove(target
, address
);
1764 gdb_put_packet(connection
, "OK", 2);
1771 if (packet
[0] == 'Z') {
1772 retval
= watchpoint_add(target
, address
, size
, wp_type
, 0, 0xffffffffu
);
1773 if (retval
!= ERROR_OK
) {
1774 retval
= gdb_error(connection
, retval
);
1775 if (retval
!= ERROR_OK
)
1778 gdb_put_packet(connection
, "OK", 2);
1780 watchpoint_remove(target
, address
);
1781 gdb_put_packet(connection
, "OK", 2);
1792 /* print out a string and allocate more space as needed,
1793 * mainly used for XML at this point
1795 static __attribute__ ((format (PRINTF_ATTRIBUTE_FORMAT
, 5, 6))) void xml_printf(int *retval
,
1796 char **xml
, int *pos
, int *size
, const char *fmt
, ...)
1798 if (*retval
!= ERROR_OK
)
1803 if ((!*xml
) || (!first
)) {
1804 /* start by 0 to exercise all the code paths.
1805 * Need minimum 2 bytes to fit 1 char and 0 terminator. */
1807 *size
= *size
* 2 + 2;
1809 *xml
= realloc(*xml
, *size
);
1812 *retval
= ERROR_SERVER_REMOTE_CLOSED
;
1820 ret
= vsnprintf(*xml
+ *pos
, *size
- *pos
, fmt
, ap
);
1822 if ((ret
> 0) && ((ret
+ 1) < *size
- *pos
)) {
1826 /* there was just enough or not enough space, allocate more. */
1831 static int decode_xfer_read(char const *buf
, char **annex
, int *ofs
, unsigned int *len
)
1833 /* Locate the annex. */
1834 const char *annex_end
= strchr(buf
, ':');
1838 /* After the read marker and annex, qXfer looks like a
1839 * traditional 'm' packet. */
1841 *ofs
= strtoul(annex_end
+ 1, &separator
, 16);
1843 if (*separator
!= ',')
1846 *len
= strtoul(separator
+ 1, NULL
, 16);
1848 /* Extract the annex if needed */
1850 *annex
= strndup(buf
, annex_end
- buf
);
1858 static int compare_bank(const void *a
, const void *b
)
1860 struct flash_bank
*b1
, *b2
;
1861 b1
= *((struct flash_bank
**)a
);
1862 b2
= *((struct flash_bank
**)b
);
1864 if (b1
->base
== b2
->base
)
1866 else if (b1
->base
> b2
->base
)
1872 static int gdb_memory_map(struct connection
*connection
,
1873 char const *packet
, int packet_size
)
1875 /* We get away with only specifying flash here. Regions that are not
1876 * specified are treated as if we provided no memory map(if not we
1877 * could detect the holes and mark them as RAM).
1878 * Normally we only execute this code once, but no big deal if we
1879 * have to regenerate it a couple of times.
1882 struct target
*target
= get_target_from_connection(connection
);
1883 struct flash_bank
*p
;
1887 int retval
= ERROR_OK
;
1888 struct flash_bank
**banks
;
1892 target_addr_t ram_start
= 0;
1893 unsigned int target_flash_banks
= 0;
1895 /* skip command character */
1898 offset
= strtoul(packet
, &separator
, 16);
1899 length
= strtoul(separator
+ 1, &separator
, 16);
1901 xml_printf(&retval
, &xml
, &pos
, &size
, "<memory-map>\n");
1903 /* Sort banks in ascending order. We need to report non-flash
1904 * memory as ram (or rather read/write) by default for GDB, since
1905 * it has no concept of non-cacheable read/write memory (i/o etc).
1907 banks
= malloc(sizeof(struct flash_bank
*)*flash_get_bank_count());
1909 for (unsigned int i
= 0; i
< flash_get_bank_count(); i
++) {
1910 p
= get_flash_bank_by_num_noprobe(i
);
1911 if (p
->target
!= target
)
1913 retval
= get_flash_bank_by_num(i
, &p
);
1914 if (retval
!= ERROR_OK
) {
1916 gdb_error(connection
, retval
);
1919 banks
[target_flash_banks
++] = p
;
1922 qsort(banks
, target_flash_banks
, sizeof(struct flash_bank
*),
1925 for (unsigned int i
= 0; i
< target_flash_banks
; i
++) {
1926 unsigned sector_size
= 0;
1927 unsigned group_len
= 0;
1931 if (ram_start
< p
->base
)
1932 xml_printf(&retval
, &xml
, &pos
, &size
,
1933 "<memory type=\"ram\" start=\"" TARGET_ADDR_FMT
"\" "
1934 "length=\"" TARGET_ADDR_FMT
"\"/>\n",
1935 ram_start
, p
->base
- ram_start
);
1937 /* Report adjacent groups of same-size sectors. So for
1938 * example top boot CFI flash will list an initial region
1939 * with several large sectors (maybe 128KB) and several
1940 * smaller ones at the end (maybe 32KB). STR7 will have
1941 * regions with 8KB, 32KB, and 64KB sectors; etc.
1943 for (unsigned int j
= 0; j
< p
->num_sectors
; j
++) {
1945 /* Maybe start a new group of sectors. */
1946 if (sector_size
== 0) {
1947 if (p
->sectors
[j
].offset
+ p
->sectors
[j
].size
> p
->size
) {
1948 LOG_WARNING("The flash sector at offset 0x%08" PRIx32
1949 " overflows the end of %s bank.",
1950 p
->sectors
[j
].offset
, p
->name
);
1951 LOG_WARNING("The rest of bank will not show in gdb memory map.");
1954 target_addr_t start
;
1955 start
= p
->base
+ p
->sectors
[j
].offset
;
1956 xml_printf(&retval
, &xml
, &pos
, &size
,
1957 "<memory type=\"flash\" "
1958 "start=\"" TARGET_ADDR_FMT
"\" ",
1960 sector_size
= p
->sectors
[j
].size
;
1961 group_len
= sector_size
;
1963 group_len
+= sector_size
; /* equal to p->sectors[j].size */
1966 /* Does this finish a group of sectors?
1967 * If not, continue an already-started group.
1969 if (j
< p
->num_sectors
- 1
1970 && p
->sectors
[j
+ 1].size
== sector_size
1971 && p
->sectors
[j
+ 1].offset
== p
->sectors
[j
].offset
+ sector_size
1972 && p
->sectors
[j
+ 1].offset
+ p
->sectors
[j
+ 1].size
<= p
->size
)
1975 xml_printf(&retval
, &xml
, &pos
, &size
,
1976 "length=\"0x%x\">\n"
1977 "<property name=\"blocksize\">"
1985 ram_start
= p
->base
+ p
->size
;
1989 xml_printf(&retval
, &xml
, &pos
, &size
,
1990 "<memory type=\"ram\" start=\"" TARGET_ADDR_FMT
"\" "
1991 "length=\"" TARGET_ADDR_FMT
"\"/>\n",
1992 ram_start
, target_address_max(target
) - ram_start
+ 1);
1993 /* ELSE a flash chip could be at the very end of the address space, in
1994 * which case ram_start will be precisely 0 */
1998 xml_printf(&retval
, &xml
, &pos
, &size
, "</memory-map>\n");
2000 if (retval
!= ERROR_OK
) {
2002 gdb_error(connection
, retval
);
2006 if (offset
+ length
> pos
)
2007 length
= pos
- offset
;
2009 char *t
= malloc(length
+ 1);
2011 memcpy(t
+ 1, xml
+ offset
, length
);
2012 gdb_put_packet(connection
, t
, length
+ 1);
2019 static const char *gdb_get_reg_type_name(enum reg_type type
)
2028 case REG_TYPE_INT16
:
2030 case REG_TYPE_INT32
:
2032 case REG_TYPE_INT64
:
2034 case REG_TYPE_INT128
:
2038 case REG_TYPE_UINT8
:
2040 case REG_TYPE_UINT16
:
2042 case REG_TYPE_UINT32
:
2044 case REG_TYPE_UINT64
:
2046 case REG_TYPE_UINT128
:
2048 case REG_TYPE_CODE_PTR
:
2050 case REG_TYPE_DATA_PTR
:
2052 case REG_TYPE_FLOAT
:
2054 case REG_TYPE_IEEE_SINGLE
:
2055 return "ieee_single";
2056 case REG_TYPE_IEEE_DOUBLE
:
2057 return "ieee_double";
2058 case REG_TYPE_ARCH_DEFINED
:
2059 return "int"; /* return arbitrary string to avoid compile warning. */
2062 return "int"; /* "int" as default value */
2065 static int lookup_add_arch_defined_types(char const **arch_defined_types_list
[], const char *type_id
,
2066 int *num_arch_defined_types
)
2068 int tbl_sz
= *num_arch_defined_types
;
2070 if (type_id
&& (strcmp(type_id
, ""))) {
2071 for (int j
= 0; j
< (tbl_sz
+ 1); j
++) {
2072 if (!((*arch_defined_types_list
)[j
])) {
2073 (*arch_defined_types_list
)[tbl_sz
++] = type_id
;
2074 *arch_defined_types_list
= realloc(*arch_defined_types_list
,
2075 sizeof(char *) * (tbl_sz
+ 1));
2076 (*arch_defined_types_list
)[tbl_sz
] = NULL
;
2077 *num_arch_defined_types
= tbl_sz
;
2080 if (!strcmp((*arch_defined_types_list
)[j
], type_id
))
2089 static int gdb_generate_reg_type_description(struct target
*target
,
2090 char **tdesc
, int *pos
, int *size
, struct reg_data_type
*type
,
2091 char const **arch_defined_types_list
[], int *num_arch_defined_types
)
2093 int retval
= ERROR_OK
;
2095 if (type
->type_class
== REG_TYPE_CLASS_VECTOR
) {
2096 struct reg_data_type
*data_type
= type
->reg_type_vector
->type
;
2097 if (data_type
->type
== REG_TYPE_ARCH_DEFINED
) {
2098 if (lookup_add_arch_defined_types(arch_defined_types_list
, data_type
->id
,
2099 num_arch_defined_types
))
2100 gdb_generate_reg_type_description(target
, tdesc
, pos
, size
, data_type
,
2101 arch_defined_types_list
,
2102 num_arch_defined_types
);
2104 /* <vector id="id" type="type" count="count"/> */
2105 xml_printf(&retval
, tdesc
, pos
, size
,
2106 "<vector id=\"%s\" type=\"%s\" count=\"%" PRIu32
"\"/>\n",
2107 type
->id
, type
->reg_type_vector
->type
->id
,
2108 type
->reg_type_vector
->count
);
2110 } else if (type
->type_class
== REG_TYPE_CLASS_UNION
) {
2111 struct reg_data_type_union_field
*field
;
2112 field
= type
->reg_type_union
->fields
;
2114 struct reg_data_type
*data_type
= field
->type
;
2115 if (data_type
->type
== REG_TYPE_ARCH_DEFINED
) {
2116 if (lookup_add_arch_defined_types(arch_defined_types_list
, data_type
->id
,
2117 num_arch_defined_types
))
2118 gdb_generate_reg_type_description(target
, tdesc
, pos
, size
, data_type
,
2119 arch_defined_types_list
,
2120 num_arch_defined_types
);
2123 field
= field
->next
;
2126 * <field name="name" type="type"/> ...
2128 xml_printf(&retval
, tdesc
, pos
, size
,
2129 "<union id=\"%s\">\n",
2132 field
= type
->reg_type_union
->fields
;
2134 xml_printf(&retval
, tdesc
, pos
, size
,
2135 "<field name=\"%s\" type=\"%s\"/>\n",
2136 field
->name
, field
->type
->id
);
2138 field
= field
->next
;
2141 xml_printf(&retval
, tdesc
, pos
, size
,
2144 } else if (type
->type_class
== REG_TYPE_CLASS_STRUCT
) {
2145 struct reg_data_type_struct_field
*field
;
2146 field
= type
->reg_type_struct
->fields
;
2148 if (field
->use_bitfields
) {
2149 /* <struct id="id" size="size">
2150 * <field name="name" start="start" end="end"/> ...
2152 xml_printf(&retval
, tdesc
, pos
, size
,
2153 "<struct id=\"%s\" size=\"%" PRIu32
"\">\n",
2154 type
->id
, type
->reg_type_struct
->size
);
2156 xml_printf(&retval
, tdesc
, pos
, size
,
2157 "<field name=\"%s\" start=\"%" PRIu32
"\" end=\"%" PRIu32
"\" type=\"%s\" />\n",
2158 field
->name
, field
->bitfield
->start
, field
->bitfield
->end
,
2159 gdb_get_reg_type_name(field
->bitfield
->type
));
2161 field
= field
->next
;
2165 struct reg_data_type
*data_type
= field
->type
;
2166 if (data_type
->type
== REG_TYPE_ARCH_DEFINED
) {
2167 if (lookup_add_arch_defined_types(arch_defined_types_list
, data_type
->id
,
2168 num_arch_defined_types
))
2169 gdb_generate_reg_type_description(target
, tdesc
, pos
, size
, data_type
,
2170 arch_defined_types_list
,
2171 num_arch_defined_types
);
2176 * <field name="name" type="type"/> ...
2178 xml_printf(&retval
, tdesc
, pos
, size
,
2179 "<struct id=\"%s\">\n",
2182 xml_printf(&retval
, tdesc
, pos
, size
,
2183 "<field name=\"%s\" type=\"%s\"/>\n",
2184 field
->name
, field
->type
->id
);
2186 field
= field
->next
;
2190 xml_printf(&retval
, tdesc
, pos
, size
,
2193 } else if (type
->type_class
== REG_TYPE_CLASS_FLAGS
) {
2194 /* <flags id="id" size="size">
2195 * <field name="name" start="start" end="end"/> ...
2197 xml_printf(&retval
, tdesc
, pos
, size
,
2198 "<flags id=\"%s\" size=\"%" PRIu32
"\">\n",
2199 type
->id
, type
->reg_type_flags
->size
);
2201 struct reg_data_type_flags_field
*field
;
2202 field
= type
->reg_type_flags
->fields
;
2204 xml_printf(&retval
, tdesc
, pos
, size
,
2205 "<field name=\"%s\" start=\"%" PRIu32
"\" end=\"%" PRIu32
"\" type=\"%s\" />\n",
2206 field
->name
, field
->bitfield
->start
, field
->bitfield
->end
,
2207 gdb_get_reg_type_name(field
->bitfield
->type
));
2209 field
= field
->next
;
2212 xml_printf(&retval
, tdesc
, pos
, size
,
2220 /* Get a list of available target registers features. feature_list must
2221 * be freed by caller.
2223 static int get_reg_features_list(struct target
*target
, char const **feature_list
[], int *feature_list_size
,
2224 struct reg
**reg_list
, int reg_list_size
)
2228 /* Start with only one element */
2229 *feature_list
= calloc(1, sizeof(char *));
2231 for (int i
= 0; i
< reg_list_size
; i
++) {
2232 if (reg_list
[i
]->exist
== false || reg_list
[i
]->hidden
)
2235 if (reg_list
[i
]->feature
2236 && reg_list
[i
]->feature
->name
2237 && (strcmp(reg_list
[i
]->feature
->name
, ""))) {
2238 /* We found a feature, check if the feature is already in the
2239 * table. If not, allocate a new entry for the table and
2240 * put the new feature in it.
2242 for (int j
= 0; j
< (tbl_sz
+ 1); j
++) {
2243 if (!((*feature_list
)[j
])) {
2244 (*feature_list
)[tbl_sz
++] = reg_list
[i
]->feature
->name
;
2245 *feature_list
= realloc(*feature_list
, sizeof(char *) * (tbl_sz
+ 1));
2246 (*feature_list
)[tbl_sz
] = NULL
;
2249 if (!strcmp((*feature_list
)[j
], reg_list
[i
]->feature
->name
))
2256 if (feature_list_size
)
2257 *feature_list_size
= tbl_sz
;
2262 /* Create a register list that's the union of all the registers of the SMP
2263 * group this target is in. If the target is not part of an SMP group, this
2264 * returns the same as target_get_gdb_reg_list_noread().
2266 static int smp_reg_list_noread(struct target
*target
,
2267 struct reg
**combined_list
[], int *combined_list_size
,
2268 enum target_register_class reg_class
)
2271 return target_get_gdb_reg_list_noread(target
, combined_list
,
2272 combined_list_size
, REG_CLASS_ALL
);
2274 unsigned int combined_allocated
= 256;
2275 *combined_list
= malloc(combined_allocated
* sizeof(struct reg
*));
2276 if (*combined_list
== NULL
) {
2277 LOG_ERROR("malloc(%zu) failed", combined_allocated
* sizeof(struct reg
*));
2280 *combined_list_size
= 0;
2282 struct target_list
*head
;
2283 foreach_smp_target(head
, target
->smp_targets
) {
2284 struct reg
**reg_list
= NULL
;
2286 int result
= target_get_gdb_reg_list_noread(head
->target
, ®_list
,
2287 ®_list_size
, reg_class
);
2288 if (result
!= ERROR_OK
) {
2289 free(*combined_list
);
2292 for (int i
= 0; i
< reg_list_size
; i
++) {
2294 struct reg
*a
= reg_list
[i
];
2296 /* Nested loop makes this O(n^2), but this entire function with
2297 * 5 RISC-V targets takes just 2ms on my computer. Fast enough
2299 for (int j
= 0; j
< *combined_list_size
; j
++) {
2300 struct reg
*b
= (*combined_list
)[j
];
2301 if (!strcmp(a
->name
, b
->name
)) {
2303 if (a
->size
!= b
->size
) {
2304 LOG_ERROR("SMP register %s is %d bits on one "
2305 "target, but %d bits on another target.",
2306 a
->name
, a
->size
, b
->size
);
2308 free(*combined_list
);
2315 LOG_DEBUG("[%s] %s not found in combined list", target_name(target
), a
->name
);
2316 if (*combined_list_size
>= (int) combined_allocated
) {
2317 combined_allocated
*= 2;
2318 *combined_list
= realloc(*combined_list
, combined_allocated
* sizeof(struct reg
*));
2319 if (*combined_list
== NULL
) {
2320 LOG_ERROR("realloc(%zu) failed", combined_allocated
* sizeof(struct reg
*));
2324 (*combined_list
)[*combined_list_size
] = a
;
2325 (*combined_list_size
)++;
2332 /* Now warn the user about any registers that weren't found in every target. */
2333 foreach_smp_target(head
, target
->smp_targets
) {
2334 struct reg
**reg_list
= NULL
;
2336 int result
= target_get_gdb_reg_list_noread(head
->target
, ®_list
,
2337 ®_list_size
, reg_class
);
2338 if (result
!= ERROR_OK
) {
2339 free(*combined_list
);
2342 for (int i
= 0; i
< *combined_list_size
; i
++) {
2344 struct reg
*a
= (*combined_list
)[i
];
2345 for (int j
= 0; j
< reg_list_size
; j
++) {
2346 struct reg
*b
= reg_list
[j
];
2347 if (b
->exist
&& !strcmp(a
->name
, b
->name
)) {
2353 LOG_WARNING("Register %s does not exist in %s, which is part of an SMP group where "
2354 "this register does exist.",
2355 a
->name
, target_name(head
->target
));
2364 static int gdb_generate_target_description(struct target
*target
, char **tdesc_out
)
2366 int retval
= ERROR_OK
;
2367 struct reg
**reg_list
= NULL
;
2369 char const *architecture
;
2370 char const **features
= NULL
;
2371 int feature_list_size
= 0;
2377 retval
= smp_reg_list_noread(target
, ®_list
, ®_list_size
,
2380 if (retval
!= ERROR_OK
) {
2381 LOG_ERROR("get register list failed");
2382 retval
= ERROR_FAIL
;
2386 if (reg_list_size
<= 0) {
2387 LOG_ERROR("get register list failed");
2388 retval
= ERROR_FAIL
;
2392 /* Get a list of available target registers features */
2393 retval
= get_reg_features_list(target
, &features
, &feature_list_size
, reg_list
, reg_list_size
);
2394 if (retval
!= ERROR_OK
) {
2395 LOG_ERROR("Can't get the registers feature list");
2396 retval
= ERROR_FAIL
;
2400 /* If we found some features associated with registers, create sections */
2401 int current_feature
= 0;
2403 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2404 "<?xml version=\"1.0\"?>\n"
2405 "<!DOCTYPE target SYSTEM \"gdb-target.dtd\">\n"
2406 "<target version=\"1.0\">\n");
2408 /* generate architecture element if supported by target */
2409 architecture
= target_get_gdb_arch(target
);
2411 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2412 "<architecture>%s</architecture>\n", architecture
);
2414 /* generate target description according to register list */
2416 while (features
[current_feature
]) {
2417 char const **arch_defined_types
= NULL
;
2418 int num_arch_defined_types
= 0;
2420 arch_defined_types
= calloc(1, sizeof(char *));
2421 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2422 "<feature name=\"%s\">\n",
2423 features
[current_feature
]);
2426 for (i
= 0; i
< reg_list_size
; i
++) {
2428 if (reg_list
[i
]->exist
== false || reg_list
[i
]->hidden
)
2431 if (strcmp(reg_list
[i
]->feature
->name
, features
[current_feature
]))
2434 const char *type_str
;
2435 if (reg_list
[i
]->reg_data_type
) {
2436 if (reg_list
[i
]->reg_data_type
->type
== REG_TYPE_ARCH_DEFINED
) {
2437 /* generate <type... first, if there are architecture-defined types. */
2438 if (lookup_add_arch_defined_types(&arch_defined_types
,
2439 reg_list
[i
]->reg_data_type
->id
,
2440 &num_arch_defined_types
))
2441 gdb_generate_reg_type_description(target
, &tdesc
, &pos
, &size
,
2442 reg_list
[i
]->reg_data_type
,
2443 &arch_defined_types
,
2444 &num_arch_defined_types
);
2446 type_str
= reg_list
[i
]->reg_data_type
->id
;
2448 /* predefined type */
2449 type_str
= gdb_get_reg_type_name(
2450 reg_list
[i
]->reg_data_type
->type
);
2453 /* Default type is "int" */
2457 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2458 "<reg name=\"%s\"", reg_list
[i
]->name
);
2459 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2460 " bitsize=\"%" PRIu32
"\"", reg_list
[i
]->size
);
2461 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2462 " regnum=\"%" PRIu32
"\"", reg_list
[i
]->number
);
2463 if (reg_list
[i
]->caller_save
)
2464 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2465 " save-restore=\"yes\"");
2467 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2468 " save-restore=\"no\"");
2470 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2471 " type=\"%s\"", type_str
);
2473 if (reg_list
[i
]->group
)
2474 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2475 " group=\"%s\"", reg_list
[i
]->group
);
2477 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2481 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2485 free(arch_defined_types
);
2489 xml_printf(&retval
, &tdesc
, &pos
, &size
,
2496 if (retval
== ERROR_OK
)
2504 static int gdb_get_target_description_chunk(struct target
*target
, struct target_desc_format
*target_desc
,
2505 char **chunk
, int32_t offset
, uint32_t length
)
2508 LOG_ERROR("Unable to Generate Target Description");
2512 char *tdesc
= target_desc
->tdesc
;
2513 uint32_t tdesc_length
= target_desc
->tdesc_length
;
2516 int retval
= gdb_generate_target_description(target
, &tdesc
);
2517 if (retval
!= ERROR_OK
) {
2518 LOG_ERROR("Unable to Generate Target Description");
2522 tdesc_length
= strlen(tdesc
);
2527 if (length
< (tdesc_length
- offset
))
2528 transfer_type
= 'm';
2530 transfer_type
= 'l';
2532 *chunk
= malloc(length
+ 2);
2534 LOG_ERROR("Unable to allocate memory");
2538 (*chunk
)[0] = transfer_type
;
2539 if (transfer_type
== 'm') {
2540 strncpy((*chunk
) + 1, tdesc
+ offset
, length
);
2541 (*chunk
)[1 + length
] = '\0';
2543 strncpy((*chunk
) + 1, tdesc
+ offset
, tdesc_length
- offset
);
2544 (*chunk
)[1 + (tdesc_length
- offset
)] = '\0';
2546 /* After gdb-server sends out last chunk, invalidate tdesc. */
2552 target_desc
->tdesc
= tdesc
;
2553 target_desc
->tdesc_length
= tdesc_length
;
2558 static int gdb_target_description_supported(struct target
*target
, int *supported
)
2560 int retval
= ERROR_OK
;
2561 struct reg
**reg_list
= NULL
;
2562 int reg_list_size
= 0;
2563 char const **features
= NULL
;
2564 int feature_list_size
= 0;
2566 char const *architecture
= target_get_gdb_arch(target
);
2568 retval
= target_get_gdb_reg_list_noread(target
, ®_list
,
2569 ®_list_size
, REG_CLASS_ALL
);
2570 if (retval
!= ERROR_OK
) {
2571 LOG_ERROR("get register list failed");
2575 if (reg_list_size
<= 0) {
2576 LOG_ERROR("get register list failed");
2577 retval
= ERROR_FAIL
;
2581 /* Get a list of available target registers features */
2582 retval
= get_reg_features_list(target
, &features
, &feature_list_size
, reg_list
, reg_list_size
);
2583 if (retval
!= ERROR_OK
) {
2584 LOG_ERROR("Can't get the registers feature list");
2589 if (architecture
|| feature_list_size
)
2603 static int gdb_generate_thread_list(struct target
*target
, char **thread_list_out
)
2605 struct rtos
*rtos
= target
->rtos
;
2606 int retval
= ERROR_OK
;
2607 char *thread_list
= NULL
;
2611 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2612 "<?xml version=\"1.0\"?>\n"
2616 for (int i
= 0; i
< rtos
->thread_count
; i
++) {
2617 struct thread_detail
*thread_detail
= &rtos
->thread_details
[i
];
2619 if (!thread_detail
->exists
)
2622 if (thread_detail
->thread_name_str
)
2623 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2624 "<thread id=\"%" PRIx64
"\" name=\"%s\">",
2625 thread_detail
->threadid
,
2626 thread_detail
->thread_name_str
);
2628 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2629 "<thread id=\"%" PRIx64
"\">", thread_detail
->threadid
);
2631 if (thread_detail
->thread_name_str
)
2632 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2633 "Name: %s", thread_detail
->thread_name_str
);
2635 if (thread_detail
->extra_info_str
) {
2636 if (thread_detail
->thread_name_str
)
2637 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2639 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2640 "%s", thread_detail
->extra_info_str
);
2643 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2648 xml_printf(&retval
, &thread_list
, &pos
, &size
,
2651 if (retval
== ERROR_OK
)
2652 *thread_list_out
= thread_list
;
2659 static int gdb_get_thread_list_chunk(struct target
*target
, char **thread_list
,
2660 char **chunk
, int32_t offset
, uint32_t length
)
2662 if (!*thread_list
) {
2663 int retval
= gdb_generate_thread_list(target
, thread_list
);
2664 if (retval
!= ERROR_OK
) {
2665 LOG_ERROR("Unable to Generate Thread List");
2670 size_t thread_list_length
= strlen(*thread_list
);
2673 length
= MIN(length
, thread_list_length
- offset
);
2674 if (length
< (thread_list_length
- offset
))
2675 transfer_type
= 'm';
2677 transfer_type
= 'l';
2679 *chunk
= malloc(length
+ 2 + 3);
2680 /* Allocating extra 3 bytes prevents false positive valgrind report
2681 * of strlen(chunk) word access:
2682 * Invalid read of size 4
2683 * Address 0x4479934 is 44 bytes inside a block of size 45 alloc'd */
2685 LOG_ERROR("Unable to allocate memory");
2689 (*chunk
)[0] = transfer_type
;
2690 strncpy((*chunk
) + 1, (*thread_list
) + offset
, length
);
2691 (*chunk
)[1 + length
] = '\0';
2693 /* After gdb-server sends out last chunk, invalidate thread list. */
2694 if (transfer_type
== 'l') {
2696 *thread_list
= NULL
;
2702 static int gdb_query_packet(struct connection
*connection
,
2703 char const *packet
, int packet_size
)
2705 struct command_context
*cmd_ctx
= connection
->cmd_ctx
;
2706 struct gdb_connection
*gdb_connection
= connection
->priv
;
2707 struct target
*target
= get_target_from_connection(connection
);
2709 if (strncmp(packet
, "qRcmd,", 6) == 0) {
2710 if (packet_size
> 6) {
2712 cmd
= malloc((packet_size
- 6) / 2 + 1);
2713 size_t len
= unhexify((uint8_t *)cmd
, packet
+ 6, (packet_size
- 6) / 2);
2716 /* We want to print all debug output to GDB connection */
2717 log_add_callback(gdb_log_callback
, connection
);
2718 target_call_timer_callbacks_now();
2719 /* some commands need to know the GDB connection, make note of current
2720 * GDB connection. */
2721 current_gdb_connection
= gdb_connection
;
2722 command_run_line(cmd_ctx
, cmd
);
2723 current_gdb_connection
= NULL
;
2724 target_call_timer_callbacks_now();
2725 log_remove_callback(gdb_log_callback
, connection
);
2728 gdb_put_packet(connection
, "OK", 2);
2730 } else if (strncmp(packet
, "qCRC:", 5) == 0) {
2731 if (packet_size
> 5) {
2736 target_addr_t addr
= 0;
2739 /* skip command character */
2742 addr
= strtoull(packet
, &separator
, 16);
2744 if (*separator
!= ',') {
2745 LOG_ERROR("incomplete read memory packet received, dropping connection");
2746 return ERROR_SERVER_REMOTE_CLOSED
;
2749 len
= strtoul(separator
+ 1, NULL
, 16);
2751 retval
= target_checksum_memory(target
, addr
, len
, &checksum
);
2753 if (retval
== ERROR_OK
) {
2754 snprintf(gdb_reply
, 10, "C%8.8" PRIx32
"", checksum
);
2755 gdb_put_packet(connection
, gdb_reply
, 9);
2757 retval
= gdb_error(connection
, retval
);
2758 if (retval
!= ERROR_OK
)
2764 } else if (strncmp(packet
, "qSupported", 10) == 0) {
2765 /* we currently support packet size and qXfer:memory-map:read (if enabled)
2766 * qXfer:features:read is supported for some targets */
2767 int retval
= ERROR_OK
;
2768 char *buffer
= NULL
;
2771 int gdb_target_desc_supported
= 0;
2773 /* we need to test that the target supports target descriptions */
2774 retval
= gdb_target_description_supported(target
, &gdb_target_desc_supported
);
2775 if (retval
!= ERROR_OK
) {
2776 LOG_INFO("Failed detecting Target Description Support, disabling");
2777 gdb_target_desc_supported
= 0;
2780 /* support may be disabled globally */
2781 if (gdb_use_target_description
== 0) {
2782 if (gdb_target_desc_supported
)
2783 LOG_WARNING("Target Descriptions Supported, but disabled");
2784 gdb_target_desc_supported
= 0;
2791 "PacketSize=%x;qXfer:memory-map:read%c;qXfer:features:read%c;qXfer:threads:read+;QStartNoAckMode+;vContSupported+",
2793 ((gdb_use_memory_map
== 1) && (flash_get_bank_count() > 0)) ? '+' : '-',
2794 (gdb_target_desc_supported
== 1) ? '+' : '-');
2796 if (retval
!= ERROR_OK
) {
2797 gdb_send_error(connection
, 01);
2801 gdb_put_packet(connection
, buffer
, strlen(buffer
));
2805 } else if ((strncmp(packet
, "qXfer:memory-map:read::", 23) == 0)
2806 && (flash_get_bank_count() > 0))
2807 return gdb_memory_map(connection
, packet
, packet_size
);
2808 else if (strncmp(packet
, "qXfer:features:read:", 20) == 0) {
2810 int retval
= ERROR_OK
;
2813 unsigned int length
;
2815 /* skip command character */
2818 if (decode_xfer_read(packet
, NULL
, &offset
, &length
) < 0) {
2819 gdb_send_error(connection
, 01);
2823 /* Target should prepare correct target description for annex.
2824 * The first character of returned xml is 'm' or 'l'. 'm' for
2825 * there are *more* chunks to transfer. 'l' for it is the *last*
2826 * chunk of target description.
2828 retval
= gdb_get_target_description_chunk(target
, &gdb_connection
->target_desc
,
2829 &xml
, offset
, length
);
2830 if (retval
!= ERROR_OK
) {
2831 gdb_error(connection
, retval
);
2835 gdb_put_packet(connection
, xml
, strlen(xml
));
2839 } else if (strncmp(packet
, "qXfer:threads:read:", 19) == 0) {
2841 int retval
= ERROR_OK
;
2844 unsigned int length
;
2846 /* skip command character */
2849 if (decode_xfer_read(packet
, NULL
, &offset
, &length
) < 0) {
2850 gdb_send_error(connection
, 01);
2854 /* Target should prepare correct thread list for annex.
2855 * The first character of returned xml is 'm' or 'l'. 'm' for
2856 * there are *more* chunks to transfer. 'l' for it is the *last*
2857 * chunk of target description.
2859 retval
= gdb_get_thread_list_chunk(target
, &gdb_connection
->thread_list
,
2860 &xml
, offset
, length
);
2861 if (retval
!= ERROR_OK
) {
2862 gdb_error(connection
, retval
);
2866 gdb_put_packet(connection
, xml
, strlen(xml
));
2870 } else if (strncmp(packet
, "QStartNoAckMode", 15) == 0) {
2871 gdb_connection
->noack_mode
= 1;
2872 gdb_put_packet(connection
, "OK", 2);
2876 gdb_put_packet(connection
, "", 0);
2880 static bool gdb_handle_vcont_packet(struct connection
*connection
, const char *packet
, int packet_size
)
2882 struct gdb_connection
*gdb_connection
= connection
->priv
;
2883 struct target
*target
= get_target_from_connection(connection
);
2884 const char *parse
= packet
;
2887 /* query for vCont supported */
2888 if (parse
[0] == '?') {
2889 if (target
->type
->step
) {
2890 /* gdb doesn't accept c without C and s without S */
2891 gdb_put_packet(connection
, "vCont;c;C;s;S", 13);
2897 if (parse
[0] == ';') {
2902 /* simple case, a continue packet */
2903 if (parse
[0] == 'c') {
2904 gdb_running_type
= 'c';
2905 LOG_DEBUG("target %s continue", target_name(target
));
2906 log_add_callback(gdb_log_callback
, connection
);
2907 retval
= target_resume(target
, 1, 0, 0, 0);
2908 if (retval
== ERROR_TARGET_NOT_HALTED
)
2909 LOG_INFO("target %s was not halted when resume was requested", target_name(target
));
2911 /* poll target in an attempt to make its internal state consistent */
2912 if (retval
!= ERROR_OK
) {
2913 retval
= target_poll(target
);
2914 if (retval
!= ERROR_OK
)
2915 LOG_DEBUG("error polling target %s after failed resume", target_name(target
));
2919 * We don't report errors to gdb here, move frontend_state to
2920 * TARGET_RUNNING to stay in sync with gdb's expectation of the
2923 gdb_connection
->frontend_state
= TARGET_RUNNING
;
2924 target_call_event_callbacks(target
, TARGET_EVENT_GDB_START
);
2929 /* single-step or step-over-breakpoint */
2930 if (parse
[0] == 's') {
2931 gdb_running_type
= 's';
2932 bool fake_step
= false;
2934 if (strncmp(parse
, "s:", 2) == 0) {
2935 struct target
*ct
= target
;
2943 thread_id
= strtoll(parse
, &endp
, 16);
2945 packet_size
-= endp
- parse
;
2950 /* FIXME: why is this necessary? rtos state should be up-to-date here already! */
2951 rtos_update_threads(target
);
2953 target
->rtos
->gdb_target_for_threadid(connection
, thread_id
, &ct
);
2956 * check if the thread to be stepped is the current rtos thread
2957 * if not, we must fake the step
2959 if (target
->rtos
->current_thread
!= thread_id
)
2963 if (parse
[0] == ';') {
2967 if (parse
[0] == 'c') {
2970 /* check if thread-id follows */
2971 if (parse
[0] == ':') {
2975 tid
= strtoll(parse
, &endp
, 16);
2976 if (tid
== thread_id
) {
2978 * Special case: only step a single thread (core),
2979 * keep the other threads halted. Currently, only
2980 * aarch64 target understands it. Other target types don't
2981 * care (nobody checks the actual value of 'current')
2982 * and it doesn't really matter. This deserves
2983 * a symbolic constant and a formal interface documentation
2986 LOG_DEBUG("request to step current core only");
2987 /* uncomment after checking that indeed other targets are safe */
2994 LOG_DEBUG("target %s single-step thread %"PRIx64
, target_name(ct
), thread_id
);
2995 log_add_callback(gdb_log_callback
, connection
);
2996 target_call_event_callbacks(ct
, TARGET_EVENT_GDB_START
);
2999 * work around an annoying gdb behaviour: when the current thread
3000 * is changed in gdb, it assumes that the target can follow and also
3001 * make the thread current. This is an assumption that cannot hold
3002 * for a real target running a multi-threading OS. We just fake
3003 * the step to not trigger an internal error in gdb. See
3004 * https://sourceware.org/bugzilla/show_bug.cgi?id=22925 for details
3008 char sig_reply
[128];
3010 LOG_DEBUG("fake step thread %"PRIx64
, thread_id
);
3012 sig_reply_len
= snprintf(sig_reply
, sizeof(sig_reply
),
3013 "T05thread:%016"PRIx64
";", thread_id
);
3015 gdb_put_packet(connection
, sig_reply
, sig_reply_len
);
3016 log_remove_callback(gdb_log_callback
, connection
);
3021 /* support for gdb_sync command */
3022 if (gdb_connection
->sync
) {
3023 gdb_connection
->sync
= false;
3024 if (ct
->state
== TARGET_HALTED
) {
3025 LOG_DEBUG("stepi ignored. GDB will now fetch the register state "
3026 "from the target.");
3027 gdb_sig_halted(connection
);
3028 log_remove_callback(gdb_log_callback
, connection
);
3030 gdb_connection
->frontend_state
= TARGET_RUNNING
;
3034 retval
= target_step(ct
, current_pc
, 0, 0);
3035 if (retval
== ERROR_TARGET_NOT_HALTED
)
3036 LOG_INFO("target %s was not halted when step was requested", target_name(ct
));
3038 /* if step was successful send a reply back to gdb */
3039 if (retval
== ERROR_OK
) {
3040 retval
= target_poll(ct
);
3041 if (retval
!= ERROR_OK
)
3042 LOG_DEBUG("error polling target %s after successful step", target_name(ct
));
3043 /* send back signal information */
3044 gdb_signal_reply(ct
, connection
);
3045 /* stop forwarding log packets! */
3046 log_remove_callback(gdb_log_callback
, connection
);
3048 gdb_connection
->frontend_state
= TARGET_RUNNING
;
3050 LOG_ERROR("Unknown vCont packet");
3059 static char *next_hex_encoded_field(const char **str
, char sep
)
3062 const char *hex
= *str
;
3066 const char *end
= strchr(hex
, sep
);
3068 hexlen
= strlen(hex
);
3071 *str
= hex
+ hexlen
+ 1;
3073 if (hexlen
% 2 != 0) {
3074 /* Malformed hex data */
3078 size_t count
= hexlen
/ 2;
3079 char *decoded
= malloc(count
+ 1);
3083 size_t converted
= unhexify((void *)decoded
, hex
, count
);
3084 if (converted
!= count
) {
3089 decoded
[count
] = '\0';
3093 /* handle extended restart packet */
3094 static void gdb_restart_inferior(struct connection
*connection
, const char *packet
, int packet_size
)
3096 struct gdb_connection
*gdb_con
= connection
->priv
;
3097 struct target
*target
= get_target_from_connection(connection
);
3099 breakpoint_clear_target(target
);
3100 watchpoint_clear_target(target
);
3101 command_run_linef(connection
->cmd_ctx
, "ocd_gdb_restart %s",
3102 target_name(target
));
3103 /* set connection as attached after reset */
3104 gdb_con
->attached
= true;
3105 /* info rtos parts */
3106 gdb_thread_packet(connection
, packet
, packet_size
);
3109 static bool gdb_handle_vrun_packet(struct connection
*connection
, const char *packet
, int packet_size
)
3111 struct target
*target
= get_target_from_connection(connection
);
3112 const char *parse
= packet
;
3117 if (parse
[0] != ';')
3121 /* Skip first field "filename"; don't know what to do with it. */
3122 free(next_hex_encoded_field(&parse
, ';'));
3124 char *cmdline
= next_hex_encoded_field(&parse
, ';');
3126 char *arg
= next_hex_encoded_field(&parse
, ';');
3129 char *new_cmdline
= alloc_printf("%s %s", cmdline
, arg
);
3132 cmdline
= new_cmdline
;
3136 if (target
->semihosting
) {
3137 LOG_INFO("GDB set inferior command line to '%s'", cmdline
);
3138 free(target
->semihosting
->cmdline
);
3139 target
->semihosting
->cmdline
= cmdline
;
3141 LOG_INFO("GDB set inferior command line to '%s' but semihosting is unavailable", cmdline
);
3146 gdb_restart_inferior(connection
, packet
, packet_size
);
3147 gdb_put_packet(connection
, "S00", 3);
3151 static int gdb_v_packet(struct connection
*connection
,
3152 char const *packet
, int packet_size
)
3154 struct gdb_connection
*gdb_connection
= connection
->priv
;
3157 struct target
*target
= get_target_from_connection(connection
);
3159 if (strncmp(packet
, "vCont", 5) == 0) {
3165 handled
= gdb_handle_vcont_packet(connection
, packet
, packet_size
);
3167 gdb_put_packet(connection
, "", 0);
3172 if (strncmp(packet
, "vRun", 4) == 0) {
3175 handled
= gdb_handle_vrun_packet(connection
, packet
, packet_size
);
3177 gdb_put_packet(connection
, "", 0);
3182 /* if flash programming disabled - send a empty reply */
3184 if (gdb_flash_program
== 0) {
3185 gdb_put_packet(connection
, "", 0);
3189 if (strncmp(packet
, "vFlashErase:", 12) == 0) {
3191 unsigned long length
;
3193 char const *parse
= packet
+ 12;
3194 if (*parse
== '\0') {
3195 LOG_ERROR("incomplete vFlashErase packet received, dropping connection");
3196 return ERROR_SERVER_REMOTE_CLOSED
;
3199 addr
= strtoul(parse
, (char **)&parse
, 16);
3201 if (*(parse
++) != ',' || *parse
== '\0') {
3202 LOG_ERROR("incomplete vFlashErase packet received, dropping connection");
3203 return ERROR_SERVER_REMOTE_CLOSED
;
3206 length
= strtoul(parse
, (char **)&parse
, 16);
3208 if (*parse
!= '\0') {
3209 LOG_ERROR("incomplete vFlashErase packet received, dropping connection");
3210 return ERROR_SERVER_REMOTE_CLOSED
;
3213 /* assume all sectors need erasing - stops any problems
3214 * when flash_write is called multiple times */
3217 /* perform any target specific operations before the erase */
3218 target_call_event_callbacks(target
,
3219 TARGET_EVENT_GDB_FLASH_ERASE_START
);
3221 /* vFlashErase:addr,length messages require region start and
3222 * end to be "block" aligned ... if padding is ever needed,
3223 * GDB will have become dangerously confused.
3225 result
= flash_erase_address_range(target
, false, addr
,
3228 /* perform any target specific operations after the erase */
3229 target_call_event_callbacks(target
,
3230 TARGET_EVENT_GDB_FLASH_ERASE_END
);
3233 if (result
!= ERROR_OK
) {
3234 /* GDB doesn't evaluate the actual error number returned,
3235 * treat a failed erase as an I/O error
3237 gdb_send_error(connection
, EIO
);
3238 LOG_ERROR("flash_erase returned %i", result
);
3240 gdb_put_packet(connection
, "OK", 2);
3245 if (strncmp(packet
, "vFlashWrite:", 12) == 0) {
3248 unsigned long length
;
3249 char const *parse
= packet
+ 12;
3251 if (*parse
== '\0') {
3252 LOG_ERROR("incomplete vFlashErase packet received, dropping connection");
3253 return ERROR_SERVER_REMOTE_CLOSED
;
3255 addr
= strtoul(parse
, (char **)&parse
, 16);
3256 if (*(parse
++) != ':') {
3257 LOG_ERROR("incomplete vFlashErase packet received, dropping connection");
3258 return ERROR_SERVER_REMOTE_CLOSED
;
3260 length
= packet_size
- (parse
- packet
);
3262 /* create a new image if there isn't already one */
3263 if (!gdb_connection
->vflash_image
) {
3264 gdb_connection
->vflash_image
= malloc(sizeof(struct image
));
3265 image_open(gdb_connection
->vflash_image
, "", "build");
3268 /* create new section with content from packet buffer */
3269 retval
= image_add_section(gdb_connection
->vflash_image
,
3270 addr
, length
, 0x0, (uint8_t const *)parse
);
3271 if (retval
!= ERROR_OK
)
3274 gdb_put_packet(connection
, "OK", 2);
3279 if (strncmp(packet
, "vFlashDone", 10) == 0) {
3282 /* process the flashing buffer. No need to erase as GDB
3283 * always issues a vFlashErase first. */
3284 target_call_event_callbacks(target
,
3285 TARGET_EVENT_GDB_FLASH_WRITE_START
);
3286 result
= flash_write(target
, gdb_connection
->vflash_image
,
3288 target_call_event_callbacks(target
,
3289 TARGET_EVENT_GDB_FLASH_WRITE_END
);
3290 if (result
!= ERROR_OK
) {
3291 if (result
== ERROR_FLASH_DST_OUT_OF_BANK
)
3292 gdb_put_packet(connection
, "E.memtype", 9);
3294 gdb_send_error(connection
, EIO
);
3296 LOG_DEBUG("wrote %u bytes from vFlash image to flash", (unsigned)written
);
3297 gdb_put_packet(connection
, "OK", 2);
3300 image_close(gdb_connection
->vflash_image
);
3301 free(gdb_connection
->vflash_image
);
3302 gdb_connection
->vflash_image
= NULL
;
3307 gdb_put_packet(connection
, "", 0);
3311 static int gdb_detach(struct connection
*connection
)
3314 * Only reply "OK" to GDB
3315 * it will close the connection and this will trigger a call to
3316 * gdb_connection_closed() that will in turn trigger the event
3317 * TARGET_EVENT_GDB_DETACH
3319 return gdb_put_packet(connection
, "OK", 2);
3322 /* The format of 'F' response packet is
3323 * Fretcode,errno,Ctrl-C flag;call-specific attachment
3325 static int gdb_fileio_response_packet(struct connection
*connection
,
3326 char const *packet
, int packet_size
)
3328 struct target
*target
= get_target_from_connection(connection
);
3330 char *parsing_point
;
3331 int fileio_retcode
= strtoul(packet
+ 1, &separator
, 16);
3332 int fileio_errno
= 0;
3333 bool fileio_ctrl_c
= false;
3338 if (*separator
== ',') {
3339 parsing_point
= separator
+ 1;
3340 fileio_errno
= strtoul(parsing_point
, &separator
, 16);
3341 if (*separator
== ',') {
3342 if (*(separator
+ 1) == 'C') {
3343 /* TODO: process ctrl-c */
3344 fileio_ctrl_c
= true;
3349 LOG_DEBUG("File-I/O response, retcode: 0x%x, errno: 0x%x, ctrl-c: %s",
3350 fileio_retcode
, fileio_errno
, fileio_ctrl_c
? "true" : "false");
3352 retval
= target_gdb_fileio_end(target
, fileio_retcode
, fileio_errno
, fileio_ctrl_c
);
3353 if (retval
!= ERROR_OK
)
3356 /* After File-I/O ends, keep continue or step */
3357 if (gdb_running_type
== 'c')
3358 retval
= target_resume(target
, 1, 0x0, 0, 0);
3359 else if (gdb_running_type
== 's')
3360 retval
= target_step(target
, 1, 0x0, 0);
3362 retval
= ERROR_FAIL
;
3364 if (retval
!= ERROR_OK
)
3370 static void gdb_log_callback(void *priv
, const char *file
, unsigned line
,
3371 const char *function
, const char *string
)
3373 struct connection
*connection
= priv
;
3374 struct gdb_connection
*gdb_con
= connection
->priv
;
3376 if (gdb_con
->busy
) {
3377 /* do not reply this using the O packet */
3381 gdb_output_con(connection
, string
);
3384 static void gdb_sig_halted(struct connection
*connection
)
3387 snprintf(sig_reply
, 4, "T%2.2x", 2);
3388 gdb_put_packet(connection
, sig_reply
, 3);
3391 static int gdb_input_inner(struct connection
*connection
)
3393 /* Do not allocate this on the stack */
3394 static char gdb_packet_buffer
[GDB_BUFFER_SIZE
+ 1]; /* Extra byte for null-termination */
3396 struct target
*target
;
3397 char const *packet
= gdb_packet_buffer
;
3400 struct gdb_connection
*gdb_con
= connection
->priv
;
3401 static bool warn_use_ext
;
3403 target
= get_target_from_connection(connection
);
3405 /* drain input buffer. If one of the packets fail, then an error
3406 * packet is replied, if applicable.
3408 * This loop will terminate and the error code is returned.
3410 * The calling fn will check if this error is something that
3411 * can be recovered from, or if the connection must be closed.
3413 * If the error is recoverable, this fn is called again to
3414 * drain the rest of the buffer.
3417 packet_size
= GDB_BUFFER_SIZE
;
3418 retval
= gdb_get_packet(connection
, gdb_packet_buffer
, &packet_size
);
3419 if (retval
!= ERROR_OK
)
3422 /* terminate with zero */
3423 gdb_packet_buffer
[packet_size
] = '\0';
3425 gdb_log_incoming_packet(gdb_packet_buffer
);
3427 if (packet_size
> 0) {
3429 switch (packet
[0]) {
3430 case 'T': /* Is thread alive? */
3431 gdb_thread_packet(connection
, packet
, packet_size
);
3433 case 'H': /* Set current thread ( 'c' for step and continue,
3434 * 'g' for all other operations ) */
3435 gdb_thread_packet(connection
, packet
, packet_size
);
3439 retval
= gdb_thread_packet(connection
, packet
, packet_size
);
3440 if (retval
== GDB_THREAD_PACKET_NOT_CONSUMED
)
3441 retval
= gdb_query_packet(connection
, packet
, packet_size
);
3444 retval
= gdb_get_registers_packet(connection
, packet
, packet_size
);
3447 retval
= gdb_set_registers_packet(connection
, packet
, packet_size
);
3450 retval
= gdb_get_register_packet(connection
, packet
, packet_size
);
3453 retval
= gdb_set_register_packet(connection
, packet
, packet_size
);
3456 retval
= gdb_read_memory_packet(connection
, packet
, packet_size
);
3459 retval
= gdb_write_memory_packet(connection
, packet
, packet_size
);
3463 retval
= gdb_breakpoint_watchpoint_packet(connection
, packet
, packet_size
);
3466 gdb_last_signal_packet(connection
, packet
, packet_size
);
3467 /* '?' is sent after the eventual '!' */
3468 if (!warn_use_ext
&& !gdb_con
->extended_protocol
) {
3469 warn_use_ext
= true;
3470 LOG_WARNING("Prefer GDB command \"target extended-remote :%s\" instead of \"target remote :%s\"",
3471 connection
->service
->port
, connection
->service
->port
);
3477 gdb_thread_packet(connection
, packet
, packet_size
);
3478 log_add_callback(gdb_log_callback
, connection
);
3480 if (gdb_con
->mem_write_error
) {
3481 LOG_ERROR("Memory write failure!");
3483 /* now that we have reported the memory write error,
3484 * we can clear the condition */
3485 gdb_con
->mem_write_error
= false;
3488 bool nostep
= false;
3489 bool already_running
= false;
3490 if (target
->state
== TARGET_RUNNING
) {
3491 LOG_WARNING("WARNING! The target is already running. "
3492 "All changes GDB did to registers will be discarded! "
3493 "Waiting for target to halt.");
3494 already_running
= true;
3495 } else if (target
->state
!= TARGET_HALTED
) {
3496 LOG_WARNING("The target is not in the halted nor running stated, "
3497 "stepi/continue ignored.");
3499 } else if ((packet
[0] == 's') && gdb_con
->sync
) {
3500 /* Hmm..... when you issue a continue in GDB, then a "stepi" is
3501 * sent by GDB first to OpenOCD, thus defeating the check to
3502 * make only the single stepping have the sync feature...
3505 LOG_DEBUG("stepi ignored. GDB will now fetch the register state "
3506 "from the target.");
3508 gdb_con
->sync
= false;
3510 if (!already_running
&& nostep
) {
3511 /* Either the target isn't in the halted state, then we can't
3512 * step/continue. This might be early setup, etc.
3514 * Or we want to allow GDB to pick up a fresh set of
3515 * register values without modifying the target state.
3518 gdb_sig_halted(connection
);
3520 /* stop forwarding log packets! */
3521 log_remove_callback(gdb_log_callback
, connection
);
3523 /* We're running/stepping, in which case we can
3524 * forward log output until the target is halted
3526 gdb_con
->frontend_state
= TARGET_RUNNING
;
3527 target_call_event_callbacks(target
, TARGET_EVENT_GDB_START
);
3529 if (!already_running
) {
3530 /* Here we don't want packet processing to stop even if this fails,
3531 * so we use a local variable instead of retval. */
3532 retval
= gdb_step_continue_packet(connection
, packet
, packet_size
);
3533 if (retval
!= ERROR_OK
) {
3534 /* we'll never receive a halted
3535 * condition... issue a false one..
3537 gdb_frontend_halted(target
, connection
);
3544 retval
= gdb_v_packet(connection
, packet
, packet_size
);
3547 retval
= gdb_detach(connection
);
3550 retval
= gdb_write_memory_binary_packet(connection
, packet
, packet_size
);
3551 if (retval
!= ERROR_OK
)
3555 if (gdb_con
->extended_protocol
) {
3556 gdb_con
->attached
= false;
3559 gdb_put_packet(connection
, "OK", 2);
3560 return ERROR_SERVER_REMOTE_CLOSED
;
3562 /* handle extended remote protocol */
3563 gdb_con
->extended_protocol
= true;
3564 gdb_put_packet(connection
, "OK", 2);
3567 /* handle extended restart packet */
3568 gdb_restart_inferior(connection
, packet
, packet_size
);
3572 /* packet supported only by smp target i.e cortex_a.c*/
3573 /* handle smp packet replying coreid played to gbd */
3574 gdb_read_smp_packet(connection
, packet
, packet_size
);
3578 /* packet supported only by smp target i.e cortex_a.c */
3579 /* handle smp packet setting coreid to be played at next
3581 gdb_write_smp_packet(connection
, packet
, packet_size
);
3585 /* File-I/O extension */
3586 /* After gdb uses host-side syscall to complete target file
3587 * I/O, gdb sends host-side syscall return value to target
3589 * The format of 'F' response packet is
3590 * Fretcode,errno,Ctrl-C flag;call-specific attachment
3592 gdb_con
->frontend_state
= TARGET_RUNNING
;
3593 log_add_callback(gdb_log_callback
, connection
);
3594 gdb_fileio_response_packet(connection
, packet
, packet_size
);
3598 /* ignore unknown packets */
3599 LOG_DEBUG("ignoring 0x%2.2x packet", packet
[0]);
3600 gdb_put_packet(connection
, "", 0);
3604 /* if a packet handler returned an error, exit input loop */
3605 if (retval
!= ERROR_OK
)
3609 if (gdb_con
->ctrl_c
) {
3610 if (target
->state
== TARGET_RUNNING
) {
3611 struct target
*t
= target
;
3613 target
->rtos
->gdb_target_for_threadid(connection
, target
->rtos
->current_threadid
, &t
);
3614 retval
= target_halt(t
);
3615 if (retval
== ERROR_OK
)
3616 retval
= target_poll(t
);
3617 if (retval
!= ERROR_OK
)
3618 target_call_event_callbacks(target
, TARGET_EVENT_GDB_HALT
);
3619 gdb_con
->ctrl_c
= false;
3621 LOG_INFO("The target is not running when halt was requested, stopping GDB.");
3622 target_call_event_callbacks(target
, TARGET_EVENT_GDB_HALT
);
3626 } while (gdb_con
->buf_cnt
> 0);
3631 static int gdb_input(struct connection
*connection
)
3633 int retval
= gdb_input_inner(connection
);
3634 struct gdb_connection
*gdb_con
= connection
->priv
;
3635 if (retval
== ERROR_SERVER_REMOTE_CLOSED
)
3638 /* logging does not propagate the error, yet can set the gdb_con->closed flag */
3639 if (gdb_con
->closed
)
3640 return ERROR_SERVER_REMOTE_CLOSED
;
3642 /* we'll recover from any other errors(e.g. temporary timeouts, etc.) */
3646 static int gdb_target_start(struct target
*target
, const char *port
)
3648 struct gdb_service
*gdb_service
;
3650 gdb_service
= malloc(sizeof(struct gdb_service
));
3655 LOG_INFO("starting gdb server for %s on %s", target_name(target
), port
);
3657 gdb_service
->target
= target
;
3658 gdb_service
->core
[0] = -1;
3659 gdb_service
->core
[1] = -1;
3660 target
->gdb_service
= gdb_service
;
3662 ret
= add_service("gdb",
3663 port
, target
->gdb_max_connections
, &gdb_new_connection
, &gdb_input
,
3664 &gdb_connection_closed
, gdb_service
);
3665 /* initialize all targets gdb service with the same pointer */
3667 struct target_list
*head
;
3668 foreach_smp_target(head
, target
->smp_targets
) {
3669 struct target
*curr
= head
->target
;
3671 curr
->gdb_service
= gdb_service
;
3677 static int gdb_target_add_one(struct target
*target
)
3679 /* one gdb instance per smp list */
3680 if ((target
->smp
) && (target
->gdb_service
))
3683 /* skip targets that cannot handle a gdb connections (e.g. mem_ap) */
3684 if (!target_supports_gdb_connection(target
)) {
3685 LOG_DEBUG("skip gdb server for target %s", target_name(target
));
3689 if (target
->gdb_port_override
) {
3690 if (strcmp(target
->gdb_port_override
, "disabled") == 0) {
3691 LOG_INFO("gdb port disabled");
3694 return gdb_target_start(target
, target
->gdb_port_override
);
3697 if (strcmp(gdb_port
, "disabled") == 0) {
3698 LOG_INFO("gdb port disabled");
3702 int retval
= gdb_target_start(target
, gdb_port_next
);
3703 if (retval
== ERROR_OK
) {
3704 /* save the port number so can be queried with
3705 * $target_name cget -gdb-port
3707 target
->gdb_port_override
= strdup(gdb_port_next
);
3710 /* If we can parse the port number
3711 * then we increment the port number for the next target.
3714 portnumber
= strtol(gdb_port_next
, &end
, 0);
3716 if (parse_long(gdb_port_next
, &portnumber
) == ERROR_OK
) {
3717 free(gdb_port_next
);
3719 gdb_port_next
= alloc_printf("%ld", portnumber
+1);
3721 /* Don't increment if gdb_port is 0, since we're just
3722 * trying to allocate an unused port. */
3723 gdb_port_next
= strdup("0");
3731 int gdb_target_add_all(struct target
*target
)
3734 LOG_WARNING("gdb services need one or more targets defined");
3739 int retval
= gdb_target_add_one(target
);
3740 if (retval
!= ERROR_OK
)
3743 target
= target
->next
;
3749 COMMAND_HANDLER(handle_gdb_sync_command
)
3752 return ERROR_COMMAND_SYNTAX_ERROR
;
3754 if (!current_gdb_connection
) {
3756 "gdb_sync command can only be run from within gdb using \"monitor gdb_sync\"");
3760 current_gdb_connection
->sync
= true;
3765 /* daemon configuration command gdb_port */
3766 COMMAND_HANDLER(handle_gdb_port_command
)
3768 int retval
= CALL_COMMAND_HANDLER(server_pipe_command
, &gdb_port
);
3769 if (retval
== ERROR_OK
) {
3770 free(gdb_port_next
);
3771 gdb_port_next
= strdup(gdb_port
);
3776 COMMAND_HANDLER(handle_gdb_memory_map_command
)
3779 return ERROR_COMMAND_SYNTAX_ERROR
;
3781 COMMAND_PARSE_ENABLE(CMD_ARGV
[0], gdb_use_memory_map
);
3785 COMMAND_HANDLER(handle_gdb_flash_program_command
)
3788 return ERROR_COMMAND_SYNTAX_ERROR
;
3790 COMMAND_PARSE_ENABLE(CMD_ARGV
[0], gdb_flash_program
);
3794 COMMAND_HANDLER(handle_gdb_report_data_abort_command
)
3797 return ERROR_COMMAND_SYNTAX_ERROR
;
3799 COMMAND_PARSE_ENABLE(CMD_ARGV
[0], gdb_report_data_abort
);
3803 COMMAND_HANDLER(handle_gdb_report_register_access_error
)
3806 return ERROR_COMMAND_SYNTAX_ERROR
;
3808 COMMAND_PARSE_ENABLE(CMD_ARGV
[0], gdb_report_register_access_error
);
3812 /* gdb_breakpoint_override */
3813 COMMAND_HANDLER(handle_gdb_breakpoint_override_command
)
3815 if (CMD_ARGC
== 0) {
3817 } else if (CMD_ARGC
== 1) {
3818 gdb_breakpoint_override
= 1;
3819 if (strcmp(CMD_ARGV
[0], "hard") == 0)
3820 gdb_breakpoint_override_type
= BKPT_HARD
;
3821 else if (strcmp(CMD_ARGV
[0], "soft") == 0)
3822 gdb_breakpoint_override_type
= BKPT_SOFT
;
3823 else if (strcmp(CMD_ARGV
[0], "disable") == 0)
3824 gdb_breakpoint_override
= 0;
3826 return ERROR_COMMAND_SYNTAX_ERROR
;
3827 if (gdb_breakpoint_override
)
3828 LOG_USER("force %s breakpoints",
3829 (gdb_breakpoint_override_type
== BKPT_HARD
) ? "hard" : "soft");
3831 LOG_USER("breakpoint type is not overridden");
3836 COMMAND_HANDLER(handle_gdb_target_description_command
)
3839 return ERROR_COMMAND_SYNTAX_ERROR
;
3841 COMMAND_PARSE_ENABLE(CMD_ARGV
[0], gdb_use_target_description
);
3845 COMMAND_HANDLER(handle_gdb_save_tdesc_command
)
3848 uint32_t tdesc_length
;
3849 struct target
*target
= get_current_target(CMD_CTX
);
3851 int retval
= gdb_generate_target_description(target
, &tdesc
);
3852 if (retval
!= ERROR_OK
) {
3853 LOG_ERROR("Unable to Generate Target Description");
3857 tdesc_length
= strlen(tdesc
);
3859 struct fileio
*fileio
;
3860 size_t size_written
;
3862 char *tdesc_filename
= alloc_printf("%s.xml", target_type_name(target
));
3863 if (!tdesc_filename
) {
3864 retval
= ERROR_FAIL
;
3868 retval
= fileio_open(&fileio
, tdesc_filename
, FILEIO_WRITE
, FILEIO_TEXT
);
3870 if (retval
!= ERROR_OK
) {
3871 LOG_ERROR("Can't open %s for writing", tdesc_filename
);
3875 retval
= fileio_write(fileio
, tdesc_length
, tdesc
, &size_written
);
3877 fileio_close(fileio
);
3879 if (retval
!= ERROR_OK
)
3880 LOG_ERROR("Error while writing the tdesc file");
3883 free(tdesc_filename
);
3889 static const struct command_registration gdb_command_handlers
[] = {
3892 .handler
= handle_gdb_sync_command
,
3893 .mode
= COMMAND_ANY
,
3894 .help
= "next stepi will return immediately allowing "
3895 "GDB to fetch register state without affecting "
3901 .handler
= handle_gdb_port_command
,
3902 .mode
= COMMAND_CONFIG
,
3903 .help
= "Normally gdb listens to a TCP/IP port. Each subsequent GDB "
3904 "server listens for the next port number after the "
3905 "base port number specified. "
3906 "No arguments reports GDB port. \"pipe\" means listen to stdin "
3907 "output to stdout, an integer is base port number, \"disabled\" disables "
3908 "port. Any other string is are interpreted as named pipe to listen to. "
3909 "Output pipe is the same name as input pipe, but with 'o' appended.",
3910 .usage
= "[port_num]",
3913 .name
= "gdb_memory_map",
3914 .handler
= handle_gdb_memory_map_command
,
3915 .mode
= COMMAND_CONFIG
,
3916 .help
= "enable or disable memory map",
3917 .usage
= "('enable'|'disable')"
3920 .name
= "gdb_flash_program",
3921 .handler
= handle_gdb_flash_program_command
,
3922 .mode
= COMMAND_CONFIG
,
3923 .help
= "enable or disable flash program",
3924 .usage
= "('enable'|'disable')"
3927 .name
= "gdb_report_data_abort",
3928 .handler
= handle_gdb_report_data_abort_command
,
3929 .mode
= COMMAND_CONFIG
,
3930 .help
= "enable or disable reporting data aborts",
3931 .usage
= "('enable'|'disable')"
3934 .name
= "gdb_report_register_access_error",
3935 .handler
= handle_gdb_report_register_access_error
,
3936 .mode
= COMMAND_CONFIG
,
3937 .help
= "enable or disable reporting register access errors",
3938 .usage
= "('enable'|'disable')"
3941 .name
= "gdb_breakpoint_override",
3942 .handler
= handle_gdb_breakpoint_override_command
,
3943 .mode
= COMMAND_ANY
,
3944 .help
= "Display or specify type of breakpoint "
3945 "to be used by gdb 'break' commands.",
3946 .usage
= "('hard'|'soft'|'disable')"
3949 .name
= "gdb_target_description",
3950 .handler
= handle_gdb_target_description_command
,
3951 .mode
= COMMAND_CONFIG
,
3952 .help
= "enable or disable target description",
3953 .usage
= "('enable'|'disable')"
3956 .name
= "gdb_save_tdesc",
3957 .handler
= handle_gdb_save_tdesc_command
,
3958 .mode
= COMMAND_EXEC
,
3959 .help
= "Save the target description file",
3962 COMMAND_REGISTRATION_DONE
3965 int gdb_register_commands(struct command_context
*cmd_ctx
)
3967 gdb_port
= strdup("3333");
3968 gdb_port_next
= strdup("3333");
3969 return register_commands(cmd_ctx
, NULL
, gdb_command_handlers
);
3972 void gdb_service_free(void)
3975 free(gdb_port_next
);