Cleanup of config/includes. 71/6171/10
authorTim Newsome <tim@sifive.com>
Mon, 19 Apr 2021 20:04:30 +0000 (13:04 -0700)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 1 May 2021 13:35:09 +0000 (14:35 +0100)
commit87c90393fedc8bb278d189aa53bcd93f4892012b
treeff2d3a460d03196d0da6a5fbb22416fa92ee0197
parentb44948985f080df55adeb9377596432fff3c50d6
Cleanup of config/includes.

Remove a use of AH_BOTTOM from configure.ac. This macro is used by
autoheader to add '#include' of some include file to the end of
config.h.in and then to config.h. OpenOCD can be built with a custom
config.h, so it's preferable to move these '#include' statement directly
in the C files that need them dropping this unneeded dependency.

It also causes problems when I want to use the gnulib library (which
comes with its own Makefile, and does not have the same include path as
the top-level Makefile).

So this change touches a lot of files, but is actually really simple. It
does not affect functionality at all.

Change-Id: I52c70bf15eb2edc1dd10e0fde23b2bcd4caec000
Signed-off-by: Tim Newsome <tim@sifive.com>
Reviewed-on: http://openocd.zylin.com/6171
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
56 files changed:
configure.ac
src/flash/common.h
src/flash/nor/bluenrg-x.c
src/helper/binarybuffer.c
src/helper/bits.h
src/helper/configuration.c
src/helper/fileio.c
src/helper/fileio.h
src/helper/log.c
src/helper/options.c
src/helper/replacements.c
src/helper/replacements.h
src/helper/system.h
src/helper/time_support.h
src/jtag/aice/aice_pipe.c
src/jtag/aice/aice_transport.c
src/jtag/aice/aice_usb.c
src/jtag/core.c
src/jtag/drivers/arm-jtag-ew.c
src/jtag/drivers/cmsis_dap.c
src/jtag/drivers/cmsis_dap_usb_bulk.c
src/jtag/drivers/cmsis_dap_usb_hid.c
src/jtag/drivers/ftdi.c
src/jtag/drivers/jlink.c
src/jtag/drivers/jtag_usb_common.c
src/jtag/drivers/jtag_usb_common.h
src/jtag/drivers/jtag_vpi.c
src/jtag/drivers/mpsse.c
src/jtag/drivers/remote_bitbang.c
src/jtag/drivers/rlink.c
src/jtag/drivers/rlink.h
src/jtag/drivers/stlink_usb.c
src/jtag/drivers/ulink.c
src/jtag/drivers/usb_blaster/ublast2_access_libusb.c
src/jtag/drivers/usb_blaster/usb_blaster.c
src/jtag/drivers/versaloon/versaloon.c
src/jtag/drivers/versaloon/versaloon_include.h
src/jtag/jtag.h
src/main.c
src/pld/pld.c
src/pld/xilinx_bit.c
src/pld/xilinx_bit.h
src/server/server.c
src/server/server.h
src/svf/svf.c
src/target/algorithm.h
src/target/armv4_5_cache.h
src/target/breakpoints.h
src/target/image.h
src/target/nds32_edm.h
src/target/register.h
src/target/semihosting_common.h
src/target/target.h
src/target/trace.h
src/transport/transport.c
src/xsvf/xsvf.c

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)