Document `struct reg` fields. 50/4250/2
authorTim Newsome <tim@sifive.com>
Sun, 8 Oct 2017 19:03:25 +0000 (12:03 -0700)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Wed, 18 Oct 2017 07:35:42 +0000 (08:35 +0100)
Change-Id: I286316079e2e4d4f09427a4ffbecadb48c5dc9d9
Signed-off-by: Tim Newsome <tim@sifive.com>
Reviewed-on: http://openocd.zylin.com/4250
Tested-by: jenkins
Reviewed-by: Liviu Ionescu <ilg@livius.net>
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
src/target/register.h

index d3b2c31c23b8e39a33ce080775cf2f9206c8e2f7..dc18e9a89935cf9038791303c1f14801c2eb9218 100644 (file)
@@ -114,17 +114,32 @@ struct reg_data_type {
 };
 
 struct reg {
+       /* Canonical name of the register. */
        const char *name;
+       /* Number that gdb uses to access this register. */
        uint32_t number;
+       /* TODO. This should probably be const. */
        struct reg_feature *feature;
+       /* TODO: When true, the caller will save this register before running any algorithm. */
        bool caller_save;
+       /* Pointer to place where the value is stored, in the format understood by
+        * the binarybuffer.h functions. */
        void *value;
+       /* The stored value needs to be written to the target. */
        bool dirty;
+       /* When true, value is valid. */
        bool valid;
+       /* When false, the register doesn't actually exist in the target. */
        bool exist;
+       /* Size of the register in bits. */
        uint32_t size;
+       /* Used for generating XML description of registers. Can be set to NULL for
+        * targets that don't use that. */
        struct reg_data_type *reg_data_type;
+       /* Used for generating XML description of registers. Can be set to NULL for
+        * targets that don't use that. */
        const char *group;
+       /* Pointer to architecture-specific info for this register. */
        void *arch_info;
        const struct reg_arch_type *type;
 };

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)