jtag/drivers/xds110: Fix compiler warning. 13/7813/4
authorTim Newsome <tim@sifive.com>
Thu, 13 Jul 2023 16:38:44 +0000 (09:38 -0700)
committerTomas Vanek <vanekt@fbl.cz>
Mon, 24 Jul 2023 07:27:24 +0000 (07:27 +0000)
Compiler would complain that `written` was used without being
initialized.

Simplify the code a little. The number of bytes written is already
checked in usb_write().

Signed-off-by: Tim Newsome <tim@sifive.com>
Change-Id: Ibada85dcccfca6f1269c584cdbc4f2e3b93bb8f3
Reviewed-on: https://review.openocd.org/c/openocd/+/7813
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Jan Matyas <jan.matyas@codasip.com>
src/jtag/drivers/xds110.c

index 371dc880349372c50b335f42d4c73fbc5bcda85d..717295c73c9b003d8b2adf90b1e7f65ef0a96196 100644 (file)
@@ -579,9 +579,6 @@ static bool usb_get_response(uint32_t *total_bytes_read, uint32_t timeout)
 
 static bool usb_send_command(uint16_t size)
 {
-       int written;
-       bool success = true;
-
        /* Check the packet length */
        if (size > USB_PAYLOAD_SIZE)
                return false;
@@ -596,13 +593,7 @@ static bool usb_send_command(uint16_t size)
        size += 3;
 
        /* Send the data via the USB connection */
-       success = usb_write(xds110.write_packet, (int)size, &written);
-
-       /* Check if the correct number of bytes was written */
-       if (written != (int)size)
-               success = false;
-
-       return success;
+       return usb_write(xds110.write_packet, (int)size, NULL);
 }
 
 /***************************************************************************

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)