flash: nor: add static to local symbols 94/7594/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 8 Apr 2023 21:59:42 +0000 (23:59 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 5 May 2023 22:08:21 +0000 (22:08 +0000)
Add static type to symbols that are not used elsewhere.

Detected through 'sparse' tool.

Change-Id: I2bdac5d2b06a6dbed5c27bfdb1cf36eee90ad823
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7594
Tested-by: jenkins
src/flash/nor/numicro.c
src/flash/nor/rsl10.c

index 0b04ce4b79888668f8a79db3c0c7c75512446669..a0c6e0c8151d177194d93c0b239abcb2f32f4249 100644 (file)
@@ -536,8 +536,8 @@ struct  numicro_flash_bank {
 };
 
 /* Private variables */
 };
 
 /* Private variables */
-uint32_t m_page_size = NUMICRO_PAGESIZE;
-uint32_t m_address_bias_offset;
+static uint32_t m_page_size = NUMICRO_PAGESIZE;
+static uint32_t m_address_bias_offset;
 
 /* Private methods */
 static int numicro_get_arm_arch(struct target *target)
 
 /* Private methods */
 static int numicro_get_arm_arch(struct target *target)
index d92c4b8b1fa582468d330ceee367f8efb43c31f3..5f0ac9b8f611db18e6fc81c9e57c7c54200a0c7c 100644 (file)
@@ -107,7 +107,7 @@ static const char *const rsl10_error_list[] = {
        [RSL10_FLASH_ERR_PROG_FAILED]       = "prog failed",
 };
 
        [RSL10_FLASH_ERR_PROG_FAILED]       = "prog failed",
 };
 
-const char *rsl10_error(enum rsl10_flash_status x)
+static const char *rsl10_error(enum rsl10_flash_status x)
 {
        if (x >= RSL10_FLASH_MAX_ERR_CODES || !rsl10_error_list[x])
                return "unknown";
 {
        if (x >= RSL10_FLASH_MAX_ERR_CODES || !rsl10_error_list[x])
                return "unknown";

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)