transport: fix segfault in transport select
authorØyvind Harboe <oyvind.harboe@zylin.com>
Wed, 7 Jul 2010 12:56:56 +0000 (14:56 +0200)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Wed, 7 Jul 2010 15:33:04 +0000 (17:33 +0200)
String compare against addresses in range 0 or so due
to not checking if there was an active session first.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/jtag/transport.c

index cee8ffb3934dfb8376c9c3cbd0d9adf0c2505a96..e431feec71f92a4df3dd4d3beaf068c618ebbbb1 100644 (file)
@@ -281,18 +281,17 @@ COMMAND_HANDLER(handle_transport_select)
                return ERROR_FAIL;
 
        case 1:                 /* "select FOO" */
-               if(strcmp(session->name, CMD_ARGV[0]) == 0) {
+               if ((session!= NULL) && strcmp(session->name, CMD_ARGV[0]) == 0) {
                        /* NOP */
                        LOG_DEBUG("transport '%s' is already selected",
                                        CMD_ARGV[0]);
                        return ERROR_OK;
                } else {
-
-               /* we can't change this session's transport after-the-fact */
-               if (session) {
-                       LOG_ERROR("session's transport is already selected.");
-                       return ERROR_FAIL;
-               }
+                       /* we can't change this session's transport after-the-fact */
+                       if (session) {
+                               LOG_ERROR("session's transport is already selected.");
+                               return ERROR_FAIL;
+                       }
                }
                break;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)