jtag/aice: use macros in place of const variables 45/6345/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Sun, 6 Jun 2021 16:14:03 +0000 (18:14 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Tue, 20 Jul 2021 13:53:40 +0000 (14:53 +0100)
Uppercase symbols are normally used for macro or enum's values.
Convert the uppercase const variables to macros.

Change-Id: I4ba47ce2d3183b50730c5a9a265f274c7b802519
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6345
Tested-by: jenkins
Reviewed-by: Marc Schink <dev@zapb.de>
Reviewed-by: Xiang W <wxjstz@126.com>
src/jtag/aice/aice_usb.c

index 3a0e48522d2bbd0d891877c412ae8c83754e8342..751fd135ca9f28313a7de283d956421a19e13981 100644 (file)
@@ -53,29 +53,29 @@ static enum aice_target_endian data_endian;
 #define AICE_FORMAT_DTHMB       (4)
 
 /* Constants for AICE command */
-static const uint8_t AICE_CMD_SCAN_CHAIN = 0x00;
-static const uint8_t AICE_CMD_T_READ_MISC = 0x20;
-static const uint8_t AICE_CMD_T_READ_EDMSR = 0x21;
-static const uint8_t AICE_CMD_T_READ_DTR = 0x22;
-static const uint8_t AICE_CMD_T_READ_MEM_B = 0x24;
-static const uint8_t AICE_CMD_T_READ_MEM_H = 0x25;
-static const uint8_t AICE_CMD_T_READ_MEM = 0x26;
-static const uint8_t AICE_CMD_T_FASTREAD_MEM = 0x27;
-static const uint8_t AICE_CMD_T_WRITE_MISC = 0x28;
-static const uint8_t AICE_CMD_T_WRITE_EDMSR    = 0x29;
-static const uint8_t AICE_CMD_T_WRITE_DTR = 0x2A;
-static const uint8_t AICE_CMD_T_WRITE_DIM = 0x2B;
-static const uint8_t AICE_CMD_T_WRITE_MEM_B = 0x2C;
-static const uint8_t AICE_CMD_T_WRITE_MEM_H = 0x2D;
-static const uint8_t AICE_CMD_T_WRITE_MEM = 0x2E;
-static const uint8_t AICE_CMD_T_FASTWRITE_MEM = 0x2F;
-static const uint8_t AICE_CMD_T_EXECUTE = 0x3E;
-static const uint8_t AICE_CMD_READ_CTRL = 0x50;
-static const uint8_t AICE_CMD_WRITE_CTRL = 0x51;
-static const uint8_t AICE_CMD_BATCH_BUFFER_READ = 0x60;
-static const uint8_t AICE_CMD_READ_DTR_TO_BUFFER = 0x61;
-static const uint8_t AICE_CMD_BATCH_BUFFER_WRITE = 0x68;
-static const uint8_t AICE_CMD_WRITE_DTR_FROM_BUFFER = 0x69;
+#define AICE_CMD_SCAN_CHAIN             0x00
+#define AICE_CMD_T_READ_MISC            0x20
+#define AICE_CMD_T_READ_EDMSR           0x21
+#define AICE_CMD_T_READ_DTR             0x22
+#define AICE_CMD_T_READ_MEM_B           0x24
+#define AICE_CMD_T_READ_MEM_H           0x25
+#define AICE_CMD_T_READ_MEM             0x26
+#define AICE_CMD_T_FASTREAD_MEM         0x27
+#define AICE_CMD_T_WRITE_MISC           0x28
+#define AICE_CMD_T_WRITE_EDMSR          0x29
+#define AICE_CMD_T_WRITE_DTR            0x2A
+#define AICE_CMD_T_WRITE_DIM            0x2B
+#define AICE_CMD_T_WRITE_MEM_B          0x2C
+#define AICE_CMD_T_WRITE_MEM_H          0x2D
+#define AICE_CMD_T_WRITE_MEM            0x2E
+#define AICE_CMD_T_FASTWRITE_MEM        0x2F
+#define AICE_CMD_T_EXECUTE              0x3E
+#define AICE_CMD_READ_CTRL              0x50
+#define AICE_CMD_WRITE_CTRL             0x51
+#define AICE_CMD_BATCH_BUFFER_READ      0x60
+#define AICE_CMD_READ_DTR_TO_BUFFER     0x61
+#define AICE_CMD_BATCH_BUFFER_WRITE     0x68
+#define AICE_CMD_WRITE_DTR_FROM_BUFFER  0x69
 
 /***************************************************************************/
 /* AICE commands' pack/unpack functions */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)