flash/nor: remove useless bank->next = NULL 85/7885/2
authorTomas Vanek <vanekt@fbl.cz>
Tue, 5 Sep 2023 16:52:38 +0000 (18:52 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 23 Sep 2023 14:31:25 +0000 (14:31 +0000)
struct flash_bank must be zeroed anyway, calloc() is always used.

Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Change-Id: I7ab3b9c66f99688c6095a0a547a05448c9e37d68
Reviewed-on: https://review.openocd.org/c/openocd/+/7885
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/flash/nor/at91sam7.c
src/flash/nor/cc26xx.c
src/flash/nor/cc3220sf.c
src/flash/nor/npcx.c

index 8bb2994ed1de4eecd12124c7a78e562685a301d1..6879a1bf23fdc8eb2d45761d7a04de0f647b78a1 100644 (file)
@@ -576,7 +576,6 @@ static int at91sam7_read_part_info(struct flash_bank *bank)
                                        return ERROR_FAIL;
                                }
                                fb->name = strdup("sam7_probed");
-                               fb->next = NULL;
 
                                /* link created bank in 'flash_banks' list */
                                t_bank->next = fb;
@@ -765,7 +764,6 @@ FLASH_BANK_COMMAND_HANDLER(at91sam7_flash_bank_command)
                                        return ERROR_FAIL;
                                }
                                fb->name = strdup("sam7_probed");
-                               fb->next = NULL;
 
                                /* link created bank in 'flash_banks' list */
                                t_bank->next = fb;
index 6256ba6e712b72e4b2afada1455ae231d0afe408..54d61421ce272088a161a7214f11650948e4a910 100644 (file)
@@ -261,7 +261,6 @@ FLASH_BANK_COMMAND_HANDLER(cc26xx_flash_bank_command)
 
        /* Finish initialization of bank */
        bank->driver_priv = cc26xx_bank;
-       bank->next = NULL;
 
        return ERROR_OK;
 }
index 432a393f8b32daa48251903c46302482fc977426..74cb7aea572358bd67c0a71a9c54eaacb5c8cbeb 100644 (file)
@@ -96,7 +96,6 @@ FLASH_BANK_COMMAND_HANDLER(cc3220sf_flash_bank_command)
 
        /* Finish initialization of flash bank */
        bank->driver_priv = cc3220sf_bank;
-       bank->next = NULL;
 
        return ERROR_OK;
 }
index 4a301f1e9816a2905f814ed5676f3cd17ad754b4..8309630d7c59b8435c4541631b946e22caacdaef 100644 (file)
@@ -331,7 +331,6 @@ FLASH_BANK_COMMAND_HANDLER(npcx_flash_bank_command)
 
        /* Finish initialization of bank */
        bank->driver_priv = npcx_bank;
-       bank->next = NULL;
 
        return ERROR_OK;
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)