Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 0a7e172)
don't return ERROR_OK in error cases 36/7236/2
authorDaniel Anselmi <danselmi@gmx.ch>
Sun, 2 Oct 2022 00:16:28 +0000 (02:16 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 8 Oct 2022 07:54:39 +0000 (07:54 +0000)
Change-Id: I7e046df85838692c9044fe9c9d67e8b2c821eb0f
Signed-off-by: Daniel Anselmi <danselmi@gmx.ch>
Reviewed-on: https://review.openocd.org/c/openocd/+/7236
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins
src/pld/virtex2.c patch | blob | history

diff --git a/src/pld/virtex2.c b/src/pld/virtex2.c
index b4861e9cb8b36c0ac6426352974421f2cafe2ac0..98fd58adbbc8fba74d80c01c6e376edd91b2b02d 100644 (file)
--- a/src/pld/virtex2.c
+++ b/src/pld/virtex2.c
@@ -175,7 +175,7 @@ COMMAND_HANDLER(virtex2_handle_read_stat_command)
        device = get_pld_device_by_num(dev_id);
        if (!device) {
                command_print(CMD, "pld device '#%s' is out of bounds", CMD_ARGV[0]);
        device = get_pld_device_by_num(dev_id);
        if (!device) {
                command_print(CMD, "pld device '#%s' is out of bounds", CMD_ARGV[0]);
-               return ERROR_OK;
+               return ERROR_FAIL;
        }
 
        virtex2_read_stat(device, &status);
        }
 
        virtex2_read_stat(device, &status);
@@ -197,7 +197,7 @@ PLD_DEVICE_COMMAND_HANDLER(virtex2_pld_device_command)
        tap = jtag_tap_by_string(CMD_ARGV[1]);
        if (!tap) {
                command_print(CMD, "Tap: %s does not exist", CMD_ARGV[1]);
        tap = jtag_tap_by_string(CMD_ARGV[1]);
        if (!tap) {
                command_print(CMD, "Tap: %s does not exist", CMD_ARGV[1]);
-               return ERROR_OK;
+               return ERROR_FAIL;
        }
 
        virtex2_info = malloc(sizeof(struct virtex2_pld_device));
        }
 
        virtex2_info = malloc(sizeof(struct virtex2_pld_device));
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)